Bug 138754 - Remove computeTextPaintStyle's RenderText dependency.
Summary: Remove computeTextPaintStyle's RenderText dependency.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-11-14 13:58 PST by zalan
Modified: 2014-11-14 16:26 PST (History)
6 users (show)

See Also:

Attachments
Patch (5.70 KB, patch)
2014-11-14 14:05 PST, zalan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2014-11-14 13:58:21 PST 
from
TextPaintStyle computeTextPaintStyle(const RenderText&, const RenderStyle&, const PaintInfo&);
to
TextPaintStyle computeTextPaintStyle(const Frame&, const RenderStyle&, const PaintInfo&);

So that in simple line layout, we can compute text paint style without across multiple renderers.
Comment 1 zalan 2014-11-14 14:05:22 PST 
Created attachment 241622 [details]
Patch
Comment 2 Myles C. Maxfield 2014-11-14 14:18:47 PST 
Why is frame better than RenderText?

unofficial r=me
Comment 3 WebKit Commit Bot 2014-11-14 16:26:53 PST 
Comment on attachment 241622 [details]
Patch

Clearing flags on attachment: 241622

Committed r176147: <http://trac.webkit.org/changeset/176147>
Comment 4 WebKit Commit Bot 2014-11-14 16:26:57 PST 
All reviewed patches have been landed.  Closing bug.