RESOLVED FIXED 138751
[iOS] QuartzCore SPI not available in public SDK 
https://bugs.webkit.org/show_bug.cgi?id=138751
Summary [iOS] QuartzCore SPI not available in public SDK
Daniel Bates
Reported 2014-11-14 11:46:52 PST
The iOS WebKit port makes use of the private headers from the QuartzCore framework. Towards building the port using the public SDK, we should forward declare the applicable QuartzCore SPI.
Attachments
Patch (31.33 KB, patch)
2014-11-14 11:49 PST, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Patch (31.34 KB, patch)
2014-11-14 13:16 PST, Daniel Bates 		ddkilzer: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2014-11-14 11:49:49 PST
Created attachment 241610 [details] Patch
Daniel Bates
Comment 2 2014-11-14 13:16:33 PST
Created attachment 241617 [details] Patch
David Kilzer (:ddkilzer)
Comment 3 2014-11-14 15:54:08 PST
Comment on attachment 241617 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=241617&action=review r=me > Source/WebCore/platform/ios/LegacyTileCache.mm:31 > +#include "CoreGraphicsSPI.h" Should this have been part of another patch?
Daniel Bates
Comment 4 2014-11-17 09:38:18 PST
(In reply to comment #3) > > > Source/WebCore/platform/ios/LegacyTileCache.mm:31 > > +#include "CoreGraphicsSPI.h" > > Should this have been part of another patch? No, this is appropriate for this patch. We need to fix <rdar://problem/18985152> so that we can simply include <QuartzCore/QuartzCorePrivate.h> from QuartzCoreSPI.h instead of explicitly including individual QuartzCore headers. Then we can remove this line (#include "CoreGraphicsSPI.h") since QuartzCorePrivate.h ultimately includes the appropriate CoreGraphics private header that defines CGSRegionObj.
Daniel Bates
Comment 5 2014-11-17 09:44:39 PST
Committed r176204: <http://trac.webkit.org/changeset/176204>
Daniel Bates
Comment 6 2014-11-17 10:23:01 PST
Committed Mac build fix in <https://trac.webkit.org/changeset/176205>.
Note You need to log in before you can comment on or make changes to this bug.