Bug 138751 - [iOS] QuartzCore SPI not available in public SDK
Summary: [iOS] QuartzCore SPI not available in public SDK
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: iPhone / iPad iOS 8.1
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords:
Depends on: 138709
Blocks: 136487 138756
  Show dependency tree / graph
 
Reported: 2014-11-14 11:46 PST by Daniel Bates
Modified: 2014-11-18 12:40 PST (History)
3 users (show)

See Also:

Attachments
Patch (31.33 KB, patch)
2014-11-14 11:49 PST, Daniel Bates 		no flags Details | Formatted Diff | Diff
Patch (31.34 KB, patch)
2014-11-14 13:16 PST, Daniel Bates 		ddkilzer: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2014-11-14 11:46:52 PST 
The iOS WebKit port makes use of the private headers from the QuartzCore framework. Towards building the port using the public SDK, we should forward declare the applicable QuartzCore SPI.
Comment 1 Daniel Bates 2014-11-14 11:49:49 PST 
Created attachment 241610 [details]
Patch
Comment 2 Daniel Bates 2014-11-14 13:16:33 PST 
Created attachment 241617 [details]
Patch
Comment 3 David Kilzer (:ddkilzer) 2014-11-14 15:54:08 PST 
Comment on attachment 241617 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=241617&action=review

r=me

> Source/WebCore/platform/ios/LegacyTileCache.mm:31
> +#include "CoreGraphicsSPI.h"

Should this have been part of another patch?
Comment 4 Daniel Bates 2014-11-17 09:38:18 PST 
(In reply to comment #3)
> 
> > Source/WebCore/platform/ios/LegacyTileCache.mm:31
> > +#include "CoreGraphicsSPI.h"
> 
> Should this have been part of another patch?

No, this is appropriate for this patch. We need to fix <rdar://problem/18985152> so that we can simply include <QuartzCore/QuartzCorePrivate.h> from QuartzCoreSPI.h instead of explicitly including individual QuartzCore headers. Then we can remove this line (#include "CoreGraphicsSPI.h") since QuartzCorePrivate.h ultimately includes the appropriate CoreGraphics private header that defines CGSRegionObj.
Comment 5 Daniel Bates 2014-11-17 09:44:39 PST 
Committed r176204: <http://trac.webkit.org/changeset/176204>
Comment 6 Daniel Bates 2014-11-17 10:23:01 PST 
Committed Mac build fix in <https://trac.webkit.org/changeset/176205>.