It is currently somewhat tricky to have different expectations for past and future OS X versions. Macros do the trick nicely. [ Mavericks+ ] fast/workers/shared-worker-constructor.html [ Skip ] [ Mavericks+ ] fast/workers/shared-worker-context-gc.html [ Skip ] [ Mavericks+ ] fast/workers/shared-worker-event-listener.html [ Skip ]
Created attachment 241561 [details] proposed fix
Comment on attachment 241561 [details] proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=241561&action=review > Tools/Scripts/webkitpy/port/mac.py:94 > + def configuration_specifier_macros(self): Is it worth anything to make this a little more automatic? If it just had an ordered list of release names it could work out {name}+ itself. > Tools/Scripts/webkitpy/port/mac.py:96 > + "mountainlion+": ["mavericks", "yosemite", "future"], shouldn't this include mountainlion? > Tools/Scripts/webkitpy/port/mac.py:99 > + } I assume the functionality behind this was already implemented (explaining the lack of callers added in this patch)?
Comment on attachment 241561 [details] proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=241561&action=review >> Tools/Scripts/webkitpy/port/mac.py:94 >> + def configuration_specifier_macros(self): > > Is it worth anything to make this a little more automatic? If it just had an ordered list of release names it could work out {name}+ itself. Sounds like a good idea for a future improvement. I'd prefer to get this landed and move on for now. >> Tools/Scripts/webkitpy/port/mac.py:96 >> + "mountainlion+": ["mavericks", "yosemite", "future"], > > shouldn't this include mountainlion? Actually, we don't need MountainLion+ at all, I can delete this line when landing. >> Tools/Scripts/webkitpy/port/mac.py:99 >> + } > > I assume the functionality behind this was already implemented (explaining the lack of callers added in this patch)? Yes, that's correct.
Comment on attachment 241561 [details] proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=241561&action=review >>> Tools/Scripts/webkitpy/port/mac.py:94 >>> + def configuration_specifier_macros(self): >> >> Is it worth anything to make this a little more automatic? If it just had an ordered list of release names it could work out {name}+ itself. > > Sounds like a good idea for a future improvement. I'd prefer to get this landed and move on for now. I wish we could just have one master list of os versions. Currently we have about 3.
Committed in r176127 and r176128 (for forgotten ChangeLog).