Bug 138728 – Two WKWebView internal methods are implemented in a category

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

-[WKWebView _ignoresNonWheelMouseEvents] and -[WKWebView _setIgnoresNonWheelMouseEvents:] are part of a class extension, but have implementations in WKWebView (WKPrivate), which override the synthesized accessors (since there are no overrides in the class @implementation). Fortunately the linker emits warnings about this:

ld: warning: instance method '_setIgnoresNonWheelMouseEvents:' in category from WebKit2.build/Debug/WebKit.build/Objects-normal/x86_64/WKWebView.o overrides method from class in WebKit2.build/Debug/WebKit.build/Objects-normal/x86_64/WKWebView.o


ld: warning: instance method '_ignoresNonWheelMouseEvents' in category from WebKit2.build/Debug/WebKit.build/Objects-normal/x86_64/WKWebView.o overrides method from class in WebKit2.build/Debug/WebKit.build/Objects-normal/x86_64/WKWebView.o

Created attachment 241556 [details]
Move the implementations from the category into the class

[Build Bot]

Comment on attachment 241556 [details]
Move the implementations from the category into the class

Attachment 241556 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5109783686283264

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 241559 [details]
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-13  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

Fixed in <http://trac.webkit.org/r176116>.

[Alexey Proskuryakov]

Filed bug 138743 for EWS false rejection.