Bug 138728 - Two WKWebView internal methods are implemented in a category
Summary: Two WKWebView internal methods are implemented in a category
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: mitz
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-11-13 21:57 PST by mitz
Modified: 2014-11-14 10:18 PST (History)
5 users (show)

See Also:

Attachments
Move the implementations from the category into the class (1.84 KB, patch)
2014-11-13 21:58 PST, mitz 		thorton: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2 (587.42 KB, application/zip)
2014-11-13 22:56 PST, Build Bot 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2014-11-13 21:57:14 PST 
-[WKWebView _ignoresNonWheelMouseEvents] and -[WKWebView _setIgnoresNonWheelMouseEvents:] are part of a class extension, but have implementations in WKWebView (WKPrivate), which override the synthesized accessors (since there are no overrides in the class @implementation). Fortunately the linker emits warnings about this:

ld: warning: instance method '_setIgnoresNonWheelMouseEvents:' in category from WebKit2.build/Debug/WebKit.build/Objects-normal/x86_64/WKWebView.o overrides method from class in WebKit2.build/Debug/WebKit.build/Objects-normal/x86_64/WKWebView.o


ld: warning: instance method '_ignoresNonWheelMouseEvents' in category from WebKit2.build/Debug/WebKit.build/Objects-normal/x86_64/WKWebView.o overrides method from class in WebKit2.build/Debug/WebKit.build/Objects-normal/x86_64/WKWebView.o
Comment 1 mitz 2014-11-13 21:58:37 PST 
Created attachment 241556 [details]
Move the implementations from the category into the class
Comment 2 Build Bot 2014-11-13 22:56:50 PST 
Comment on attachment 241556 [details]
Move the implementations from the category into the class

Attachment 241556 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5109783686283264

Number of test failures exceeded the failure limit.
Comment 3 Build Bot 2014-11-13 22:56:53 PST 
Created attachment 241559 [details]
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-13  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 4 mitz 2014-11-13 22:58:26 PST 
Fixed in <http://trac.webkit.org/r176116>.
Comment 5 Alexey Proskuryakov 2014-11-14 10:18:22 PST 
Filed bug 138743 for EWS false rejection.