Bug 138695 - [SOUP] Use GMainLoopSource for request timeout in ResourceHandle
Summary: [SOUP] Use GMainLoopSource for request timeout in ResourceHandle
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Soup
Depends on:
Blocks:
 
Reported: 2014-11-13 04:54 PST by Carlos Garcia Campos
Modified: 2014-11-14 01:21 PST (History)
4 users (show)

See Also:


Attachments
Patch (4.87 KB, patch)
2014-11-13 04:56 PST, Carlos Garcia Campos
svillar: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2014-11-13 04:54:47 PST
We are currently using soup_timeout_add() that simply creates a GSource and attaches it to the given context. Using GMainLoopsource we simplify the code and fix any potential problem of converting the double value into milliseconds.
Comment 1 Carlos Garcia Campos 2014-11-13 04:56:42 PST
Created attachment 241482 [details]
Patch
Comment 2 Carlos Garcia Campos 2014-11-14 01:21:52 PST
Committed r176120: <http://trac.webkit.org/changeset/176120>