Bug 138681 - Create canonical lists of registers used by both the Assemblers and the JIT probes
Summary: Create canonical lists of registers used by both the Assemblers and the JIT p...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords:
Depends on:
Blocks: 138671
  Show dependency tree / graph
 
Reported: 2014-11-12 18:04 PST by Mark Lam
Modified: 2014-11-13 08:44 PST (History)
6 users (show)

See Also:

Attachments
the patch. (14.01 KB, patch)
2014-11-12 18:13 PST, Mark Lam 		fpizlo: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2014-11-12 18:04:19 PST 
Currently they used 2 separate but parallel lists.  The 2 shall become 1.
Comment 1 Mark Lam 2014-11-12 18:13:56 PST 
Created attachment 241461 [details]
the patch.
Comment 2 WebKit Commit Bot 2014-11-12 18:15:29 PST 
Attachment 241461 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/assembler/X86Assembler.h:116:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/assembler/X86Assembler.h:118:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/assembler/X86Assembler.h:122:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/assembler/X86Assembler.h:124:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/assembler/ARMAssembler.h:103:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/assembler/ARMAssembler.h:105:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/assembler/ARMAssembler.h:117:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/assembler/ARMAssembler.h:119:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/assembler/ARMv7Assembler.h:42:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/assembler/ARMv7Assembler.h:42:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/assembler/ARMv7Assembler.h:50:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/assembler/ARMv7Assembler.h:68:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/assembler/ARMv7Assembler.h:72:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/assembler/ARMv7Assembler.h:107:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/assembler/ARMv7Assembler.h:109:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/assembler/ARMv7Assembler.h:111:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/JavaScriptCore/assembler/ARMv7Assembler.h:112:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/JavaScriptCore/assembler/ARMv7Assembler.h:113:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/JavaScriptCore/assembler/ARMv7Assembler.h:156:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/assembler/ARMv7Assembler.h:158:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
Total errors found: 20 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Mark Lam 2014-11-13 08:44:08 PST 
Thanks.  Landed in r176072: <http://trac.webkit.org/r176072>.