Bug 138677 - Web Inspector: Reduce work when activating multiple agents sequentially
Summary: Web Inspector: Reduce work when activating multiple agents sequentially
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-11-12 15:37 PST by Joseph Pecoraro
Modified: 2014-11-12 16:27 PST (History)
5 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (3.22 KB, patch)
2014-11-12 15:38 PST, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2014-11-12 15:37:17 PST 
* SUMMARY
When activating agents lazily, only do the work in handlers if the current agent is being activated. Otherwise the duplicate work could produce exceptions. E.g. Multiple PageAgent.getResourceTree calls.
Comment 1 Radar WebKit Bug Importer 2014-11-12 15:37:54 PST 
<rdar://problem/18962467>
Comment 2 Joseph Pecoraro 2014-11-12 15:38:13 PST 
Created attachment 241446 [details]
[PATCH] Proposed Fix
Comment 3 WebKit Commit Bot 2014-11-12 16:27:17 PST 
Comment on attachment 241446 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 241446

Committed r176049: <http://trac.webkit.org/changeset/176049>
Comment 4 WebKit Commit Bot 2014-11-12 16:27:21 PST 
All reviewed patches have been landed.  Closing bug.