RESOLVED FIXED 138668
WK1: Support default actions for images 
https://bugs.webkit.org/show_bug.cgi?id=138668
Summary WK1: Support default actions for images
Beth Dakin
Reported 2014-11-12 14:15:20 PST
WK1: Support default actions for images rdar://problem/18785434
Attachments
Patch (14.06 KB, patch)
2014-11-12 14:18 PST, Beth Dakin 		thorton: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Beth Dakin
Comment 1 2014-11-12 14:18:30 PST
Created attachment 241442 [details] Patch
WebKit Commit Bot
Comment 2 2014-11-12 14:20:02 PST
Attachment 241442 [details] did not pass style-queue: ERROR: Source/WebKit/mac/WebView/WebActionMenuController.mm:47: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Tim Horton
Comment 3 2014-11-12 14:23:40 PST
Comment on attachment 241442 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=241442&action=review > Source/WebKit/mac/WebView/WebActionMenuController.mm:62 > +SOFT_LINK_FRAMEWORK_IN_UMBRELLA(Quartz, ImageKit) Newline above here, I think. > Source/WebKit/mac/WebView/WebActionMenuController.mm:303 > +static NSString *temporaryPhotosDirectoryPath() Now we have this three times :D We should merge them all back down again eventually.
Beth Dakin
Comment 4 2014-11-12 14:52:53 PST
Thanks Tim! http://trac.webkit.org/changeset/176041
Note You need to log in before you can comment on or make changes to this bug.