Bug 138668 - WK1: Support default actions for images
Summary: WK1: Support default actions for images
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-11-12 14:15 PST by Beth Dakin
Modified: 2014-11-12 14:52 PST (History)
4 users (show)

See Also:

Attachments
Patch (14.06 KB, patch)
2014-11-12 14:18 PST, Beth Dakin 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Beth Dakin 2014-11-12 14:15:20 PST 
WK1: Support default actions for images

rdar://problem/18785434
Comment 1 Beth Dakin 2014-11-12 14:18:30 PST 
Created attachment 241442 [details]
Patch
Comment 2 WebKit Commit Bot 2014-11-12 14:20:02 PST 
Attachment 241442 [details] did not pass style-queue:


ERROR: Source/WebKit/mac/WebView/WebActionMenuController.mm:47:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Tim Horton 2014-11-12 14:23:40 PST 
Comment on attachment 241442 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=241442&action=review

> Source/WebKit/mac/WebView/WebActionMenuController.mm:62
> +SOFT_LINK_FRAMEWORK_IN_UMBRELLA(Quartz, ImageKit)

Newline above here, I think.

> Source/WebKit/mac/WebView/WebActionMenuController.mm:303
> +static NSString *temporaryPhotosDirectoryPath()

Now we have this three times :D We should merge them all back down again eventually.
Comment 4 Beth Dakin 2014-11-12 14:52:53 PST 
Thanks Tim!

http://trac.webkit.org/changeset/176041