Bug 138664 - Need to show the text indicator when Data Detectors shows a popover
Summary: Need to show the text indicator when Data Detectors shows a popover
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-11-12 13:16 PST by Tim Horton
Modified: 2014-11-12 15:25 PST (History)
3 users (show)

See Also:

Attachments
Patch (8.39 KB, patch)
2014-11-12 13:16 PST, Tim Horton 		bdakin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2014-11-12 13:16:12 PST 
Need to show the text indicator when Data Detectors shows a popover
Comment 1 Tim Horton 2014-11-12 13:16:45 PST 
Created attachment 241437 [details]
Patch
Comment 2 Tim Horton 2014-11-12 13:17:11 PST 
<rdar://problem/18869900>
Comment 3 WebKit Commit Bot 2014-11-12 13:19:01 PST 
Attachment 241437 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:57:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:588:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:589:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:591:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:597:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 5 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Tim Horton 2014-11-12 13:51:01 PST 
http://trac.webkit.org/changeset/176037
Comment 5 Tim Horton 2014-11-12 15:25:33 PST 
and http://trac.webkit.org/changeset/176044