Bug 138640 – Modernize $buildingForIPhone in CodeGeneratorObjC.pm

• Status: RESOLVED
• Resolution: FIXED
• Component: Bindings

[David Kilzer (:ddkilzer)]

Mac OS X is the only platform that supports NSColor, so rename $buildingForIPhone to $shouldUseCGColor (which is actually what the variable represents) and define it in terms of the "macosx" platform name.

[David Kilzer (:ddkilzer)]

Created attachment 241394 [details]
Patch v1

[David Kilzer (:ddkilzer)]

<rdar://problem/18919000>

[Daniel Bates]

Comment on attachment 241394 [details]
Patch v1

OK.

[Mark Rowe (bdash)]

Comment on attachment 241394 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=241394&action=review

> Source/WebCore/ChangeLog:3
> +        Modernize $buildingForIPhone in CodeGeneratorObjC.pm

"Modernize" is a strange way of saying "rename".

[WebKit Commit Bot]

Comment on attachment 241394 [details]
Patch v1

Clearing flags on attachment: 241394

Committed r175995: <http://trac.webkit.org/changeset/175995>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[David Kilzer (:ddkilzer)]

(In reply to comment #4)
> Comment on attachment 241394 [details]
> Patch v1
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=241394&action=review
> 
> > Source/WebCore/ChangeLog:3
> > +        Modernize $buildingForIPhone in CodeGeneratorObjC.pm
> 
> "Modernize" is a strange way of saying "rename".

That's because it wasn't just a variable rename; I changed the logic of how the variable was defined and removed some cruft.