Bug 138639 - Web Inspector: Handle activating extra agents properly after inspector has connected
Summary: Web Inspector: Handle activating extra agents properly after inspector has co...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-11-11 15:57 PST by Joseph Pecoraro
Modified: 2014-11-11 19:07 PST (History)
6 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (8.46 KB, patch)
2014-11-11 15:59 PST, Joseph Pecoraro 		timothy: review+
joepeck: commit-queue-
Details | Formatted Diff | Diff
[PATCH] Rebased Tests (14.47 KB, patch)
2014-11-11 16:21 PST, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2014-11-11 15:57:48 PST 
* SUMMARY
If extra agents are registered after an inspector has connected, they don't get activated. This can be a common scenario when auto-attaching an inspector to a JSContext before that JSContext has had an opportunity to add extra agents.
Comment 1 Radar WebKit Bug Importer 2014-11-11 15:58:02 PST 
<rdar://problem/18947710>
Comment 2 Joseph Pecoraro 2014-11-11 15:59:49 PST 
Created attachment 241388 [details]
[PATCH] Proposed Fix
Comment 3 WebKit Commit Bot 2014-11-11 16:00:52 PST 
This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)
Comment 4 Joseph Pecoraro 2014-11-11 16:13:59 PST 
Comment on attachment 241388 [details]
[PATCH] Proposed Fix

Oops, I should rebaseline generated results.
Comment 5 Joseph Pecoraro 2014-11-11 16:21:56 PST 
Created attachment 241391 [details]
[PATCH] Rebased Tests
Comment 6 WebKit Commit Bot 2014-11-11 19:07:14 PST 
Comment on attachment 241391 [details]
[PATCH] Rebased Tests

Clearing flags on attachment: 241391

Committed r175999: <http://trac.webkit.org/changeset/175999>
Comment 7 WebKit Commit Bot 2014-11-11 19:07:17 PST 
All reviewed patches have been landed.  Closing bug.