RESOLVED FIXED138630
build.webkit.org/dashboard shows obsolete results when builds are substantially out of order 
https://bugs.webkit.org/show_bug.cgi?id=138630
Summary build.webkit.org/dashboard shows obsolete results when builds are substantial...
Alexey Proskuryakov
Reported 2014-11-11 14:27:53 PST
For this sequence of builds (newest at top), the dashboard decides that r175872 is the most recent revision, and r175866 is the last successful build. But it's actually r175886 that is the most recent. Nov 11 06:40 175858 success #158 Build successful Nov 11 05:48 175859 success #157 Build successful Nov 11 05:47 175860 success #156 Build successful Nov 11 05:17 175866 success #155 Build successful Nov 11 05:17 175865 success #154 Build successful Nov 11 05:14 175870 failure #153 Failed build archive Nov 11 04:51 175869 failure #152 Failed build archive Nov 11 04:44 175872 failure #151 Failed build archive Nov 11 03:57 175871 failure #150 Failed build archive Nov 11 03:54 175879 success #149 Build successful Nov 11 03:52 175878 success #148 Build successful Nov 11 03:52 175877 success #147 Build successful Nov 11 03:00 175886 success #146 Build successful Nov 11 02:36 175876 success #145 Build successful Nov 11 02:31 175875 success #144 Build successful Nov 11 02:28 175874 success #143 Build successful Nov 11 02:26 175873 failure #142 Failed build archive Nov 11 01:34 175881 success #141 Build successful Nov 11 01:16 175864 success #140 Build successful I am not sure if there is a way to fix this other than by fetching a lot more revisions upfront.
Attachments
proposed fix (5.64 KB, patch)
2015-04-13 12:46 PDT, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2015-04-13 12:34:32 PDT
I don't think that the above example accurately represents what happens for out of order builds. We would not have something like this: > Nov 11 05:47 175860 success #156 Build successful > Nov 11 05:17 175866 success #155 Build successful > Nov 11 05:17 175865 success #154 Build successful How it works is that out of order builds appear to always happen in descending order. This gives us a way to identify out of order builds, and to ignore them when deciding whether we have the results for recent commits.
Alexey Proskuryakov
Comment 2 2015-04-13 12:46:59 PDT
Created attachment 250667 [details] proposed fix
Alexey Proskuryakov
Comment 3 2015-04-13 16:22:15 PDT
Of course, the dashboard would still be confused if there are many builds scheduled manually.
WebKit Commit Bot
Comment 4 2015-04-13 17:09:29 PDT
Comment on attachment 250667 [details] proposed fix Clearing flags on attachment: 250667 Committed r182770: <http://trac.webkit.org/changeset/182770>
WebKit Commit Bot
Comment 5 2015-04-13 17:09:32 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.