Bug 138625 - [JSC] Add more options to control FTL CodeGen
Summary: [JSC] Add more options to control FTL CodeGen
Status: RESOLVED DUPLICATE of bug 143489
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-11-11 13:10 PST by Juergen Ributzka
Modified: 2015-04-07 11:23 PDT (History)
2 users (show)

See Also:

Attachments
Patch (4.69 KB, patch)
2014-11-11 13:10 PST, Juergen Ributzka 		no flags Details | Formatted Diff | Diff
Patch (5.87 KB, patch)
2014-11-11 13:12 PST, Juergen Ributzka 		no flags Details | Formatted Diff | Diff
Patch (5.87 KB, patch)
2014-11-11 13:18 PST, Juergen Ributzka 		ggaren: review-
commit-queue: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Juergen Ributzka 2014-11-11 13:10:00 PST 
[JSC] Add more options to control FTL CodeGen
Comment 1 Juergen Ributzka 2014-11-11 13:10:28 PST 
Created attachment 241373 [details]
Patch
Comment 2 Juergen Ributzka 2014-11-11 13:12:42 PST 
Created attachment 241375 [details]
Patch
Comment 3 Geoffrey Garen 2014-11-11 13:15:38 PST 
Comment on attachment 241375 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=241375&action=review

r=me

> Source/JavaScriptCore/llvm/InitializeLLVMPOSIX.cpp:73
> +        Vector<const char *, 4> args;

WebKit style is "char*".
Comment 4 Juergen Ributzka 2014-11-11 13:18:17 PST 
Created attachment 241376 [details]
Patch
Comment 5 Geoffrey Garen 2014-11-11 13:21:14 PST 
Comment on attachment 241376 [details]
Patch

r=me
Comment 6 WebKit Commit Bot 2014-11-13 18:34:56 PST 
Comment on attachment 241376 [details]
Patch

Rejecting attachment 241376 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'build', '--no-clean', '--no-update', '--build-style=release', '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
nchor.dia -c /Volumes/Data/EWS/WebKit/Source/JavaScriptCore/llvm/library/LLVMAnchor.cpp -o /Volumes/Data/EWS/WebKit/WebKitBuild/JavaScriptCore.build/Release/llvmForJSC.build/Objects-normal/x86_64/LLVMAnchor.o

** BUILD FAILED **


The following build commands failed:
	CompileC /Volumes/Data/EWS/WebKit/WebKitBuild/JavaScriptCore.build/Release/llvmForJSC.build/Objects-normal/x86_64/LLVMExports.o llvm/library/LLVMExports.cpp normal x86_64 c++ com.apple.compilers.llvm.clang.1_0.compiler
(1 failure)

Full output: http://webkit-queues.appspot.com/results/5704957705584640
Comment 7 Geoffrey Garen 2015-03-04 11:52:57 PST 
Comment on attachment 241376 [details]
Patch

Let's come up with a way to adopt this API conditionally that doesn't break the build or harm performance when using older versions of LLVM.
Comment 8 Filip Pizlo 2015-04-07 11:23:59 PDT 

*** This bug has been marked as a duplicate of bug 143489 ***