Bug 138625 – [JSC] Add more options to control FTL CodeGen

• Status: RESOLVED
• Resolution: DUPLICATE
• Component: New Bugs

[Juergen Ributzka]

[JSC] Add more options to control FTL CodeGen

[Juergen Ributzka]

Created attachment 241373 [details]
Patch

[Juergen Ributzka]

Created attachment 241375 [details]
Patch

[Geoffrey Garen]

Comment on attachment 241375 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=241375&action=review

r=me

> Source/JavaScriptCore/llvm/InitializeLLVMPOSIX.cpp:73
> +        Vector<const char *, 4> args;

WebKit style is "char*".

[Juergen Ributzka]

Created attachment 241376 [details]
Patch

[Geoffrey Garen]

Comment on attachment 241376 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 241376 [details]
Patch

Rejecting attachment 241376 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'build', '--no-clean', '--no-update', '--build-style=release', '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
nchor.dia -c /Volumes/Data/EWS/WebKit/Source/JavaScriptCore/llvm/library/LLVMAnchor.cpp -o /Volumes/Data/EWS/WebKit/WebKitBuild/JavaScriptCore.build/Release/llvmForJSC.build/Objects-normal/x86_64/LLVMAnchor.o

** BUILD FAILED **


The following build commands failed:
	CompileC /Volumes/Data/EWS/WebKit/WebKitBuild/JavaScriptCore.build/Release/llvmForJSC.build/Objects-normal/x86_64/LLVMExports.o llvm/library/LLVMExports.cpp normal x86_64 c++ com.apple.compilers.llvm.clang.1_0.compiler
(1 failure)

Full output: http://webkit-queues.appspot.com/results/5704957705584640

[Geoffrey Garen]

Comment on attachment 241376 [details]
Patch

Let's come up with a way to adopt this API conditionally that doesn't break the build or harm performance when using older versions of LLVM.

[Filip Pizlo]

*** This bug has been marked as a duplicate of bug 143489 ***