Bug 138622 - DRT and WKTR touch disk cache
Summary: DRT and WKTR touch disk cache
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-11-11 12:21 PST by Alexey Proskuryakov
Modified: 2014-11-11 15:13 PST (History)
3 users (show)

See Also:


Attachments
proposed fix (11.42 KB, patch)
2014-11-11 12:28 PST, Alexey Proskuryakov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2014-11-11 12:21:03 PST
Both DumpRenderTree and WebKitTestRunner create a disk cache, which is wasteful and confusing.
Comment 1 Alexey Proskuryakov 2014-11-11 12:28:20 PST
Created attachment 241368 [details]
proposed fix

Need to wait for EWS, to make sure that passing a nil path doesn't break Mountain Lion.
Comment 2 WebKit Commit Bot 2014-11-11 12:30:15 PST
Attachment 241368 [details] did not pass style-queue:


ERROR: Tools/WebKitTestRunner/mac/TestControllerMac.mm:114:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Tools/WebKitTestRunner/mac/TestControllerMac.mm:115:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Tools/DumpRenderTree/mac/DumpRenderTree.mm:1096:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 3 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Geoffrey Garen 2014-11-11 12:51:26 PST
Comment on attachment 241368 [details]
proposed fix

r=me
Comment 4 WebKit Commit Bot 2014-11-11 15:13:07 PST
Comment on attachment 241368 [details]
proposed fix

Clearing flags on attachment: 241368

Committed r175982: <http://trac.webkit.org/changeset/175982>
Comment 5 WebKit Commit Bot 2014-11-11 15:13:21 PST
All reviewed patches have been landed.  Closing bug.