Bug 138614 – [iOS] cleanup wireless route monitoring

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Eric Carlson]

Cleanup.

[Eric Carlson]

<rdar://problem/18930328>

[Eric Carlson]

<rdar://problem/18940875>

[Eric Carlson]

Created attachment 241358 [details]
Proposed patch.

[WebKit Commit Bot]

Attachment 241358 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.mm:263:  Use 'WTF::move()' instead of 'std::move()'.  [runtime/wtf_move] [4]
ERROR: Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.mm:264:  Use 'WTF::move()' instead of 'std::move()'.  [runtime/wtf_move] [4]
Total errors found: 2 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Jer Noble]

Comment on attachment 241358 [details]
Proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=241358&action=review

r=me, with nits.

> Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.mm:239
> +    LOG(Media, "WebMediaSessionHelper::initWithCallback");

Maybe: "-[WebMediaSessionHelper initWithCallback]"?

> Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.mm:266
>  - (void)dealloc
>  {
> +    LOG(Media, "WebMediaSessionHelper::initWithCallback");

Really? ;)

> Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.mm:270
> +        auto volumeView = std::move(_volumeView);
> +        auto routingController = std::move(_airPlayPresenceRoutingController);

I think we're supposed to use WTF::move() now.

> Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.mm:273
> +            LOG(Media, "WebMediaSessionHelper::initWithCallback - dipatched to MainThread");

initWithCallback -> dealloc

[Eric Carlson]

Created attachment 241362 [details]
Patch for landing.

[WebKit Commit Bot]

Comment on attachment 241362 [details]
Patch for landing.

Clearing flags on attachment: 241362

Committed r175976: <http://trac.webkit.org/changeset/175976>