Bug 138614 - [iOS] cleanup wireless route monitoring
Summary: [iOS] cleanup wireless route monitoring
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-11-11 10:39 PST by Eric Carlson
Modified: 2014-11-13 18:49 PST (History)
8 users (show)

See Also:

Attachments
Proposed patch. (9.23 KB, patch)
2014-11-11 10:55 PST, Eric Carlson 		jer.noble: review+
Details | Formatted Diff | Diff
Patch for landing. (9.23 KB, patch)
2014-11-11 11:08 PST, Eric Carlson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2014-11-11 10:39:27 PST 
Cleanup.
Comment 1 Eric Carlson 2014-11-11 10:39:57 PST 
<rdar://problem/18930328>
Comment 2 Eric Carlson 2014-11-11 10:40:33 PST 
<rdar://problem/18940875>
Comment 3 Eric Carlson 2014-11-11 10:55:45 PST 
Created attachment 241358 [details]
Proposed patch.
Comment 4 WebKit Commit Bot 2014-11-11 10:58:23 PST 
Attachment 241358 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.mm:263:  Use 'WTF::move()' instead of 'std::move()'.  [runtime/wtf_move] [4]
ERROR: Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.mm:264:  Use 'WTF::move()' instead of 'std::move()'.  [runtime/wtf_move] [4]
Total errors found: 2 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Jer Noble 2014-11-11 11:01:35 PST 
Comment on attachment 241358 [details]
Proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=241358&action=review

r=me, with nits.

> Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.mm:239
> +    LOG(Media, "WebMediaSessionHelper::initWithCallback");

Maybe: "-[WebMediaSessionHelper initWithCallback]"?

> Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.mm:266
>  - (void)dealloc
>  {
> +    LOG(Media, "WebMediaSessionHelper::initWithCallback");

Really? ;)

> Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.mm:270
> +        auto volumeView = std::move(_volumeView);
> +        auto routingController = std::move(_airPlayPresenceRoutingController);

I think we're supposed to use WTF::move() now.

> Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.mm:273
> +            LOG(Media, "WebMediaSessionHelper::initWithCallback - dipatched to MainThread");

initWithCallback -> dealloc
Comment 6 Eric Carlson 2014-11-11 11:08:50 PST 
Created attachment 241362 [details]
Patch for landing.
Comment 7 WebKit Commit Bot 2014-11-11 14:03:16 PST 
Comment on attachment 241362 [details]
Patch for landing.

Clearing flags on attachment: 241362

Committed r175976: <http://trac.webkit.org/changeset/175976>