Bug 138602 - DataDetectors' menu items aren't presented in the telephone number menu
Summary: DataDetectors' menu items aren't presented in the telephone number menu
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-11-10 23:30 PST by Tim Horton
Modified: 2014-11-11 12:12 PST (History)
5 users (show)

See Also:

Attachments
Patch (9.68 KB, patch)
2014-11-10 23:30 PST, Tim Horton 		bdakin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2014-11-10 23:30:31 PST 
DataDetectors' menu items aren't presented in the telephone number menu
Comment 1 Tim Horton 2014-11-10 23:30:57 PST 
Created attachment 241338 [details]
Patch
Comment 2 Tim Horton 2014-11-10 23:31:18 PST 
<rdar://problem/18866308>
Comment 3 Conrad Shultz 2014-11-10 23:38:26 PST 
Comment on attachment 241338 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=241338&action=review

> Source/WebKit2/Platform/mac/MenuUtilities.mm:117
> +    return [menu numberOfItems] ? menu : nil;

Did you test whether this check is actually needed? In many cases, an empty NSMenu will behave as if you had no menu at all.
Comment 4 Tim Horton 2014-11-10 23:44:23 PST 
(In reply to comment #3)
> Comment on attachment 241338 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=241338&action=review
> 
> > Source/WebKit2/Platform/mac/MenuUtilities.mm:117
> > +    return [menu numberOfItems] ? menu : nil;
> 
> Did you test whether this check is actually needed? In many cases, an empty
> NSMenu will behave as if you had no menu at all.

I did not, and you're probably right. I just translated.
Comment 5 Tim Horton 2014-11-11 12:12:42 PST 
http://trac.webkit.org/changeset/175966