Bug 138579 – Web Inspector: Update Esprima, remove WebInspector.Esprima global.

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Jonathan Wells]

Need to remove the WebInspector.Esprima global object. Need to do this for two reasons. First, the combined Esprima.js file (along with all other externals) should be included before Main.js, and thus should be agnostic of the WebInspector. Secondly, from a maintenance standpoint we shouldn't be making changes to this file from the standard Esprima library. The necessary changes to the file could be forgotten in the future, so they shouldn't be done.

[Radar WebKit Bug Importer]

<rdar://problem/18931536>

[Radar WebKit Bug Importer]

<rdar://problem/18931537>

[Jonathan Wells]

Created attachment 241314 [details]
[Patch] Suggested fix.

[Joseph Pecoraro]

Comment on attachment 241314 [details]
[Patch] Suggested fix.

View in context: https://bugs.webkit.org/attachment.cgi?id=241314&action=review

> Source/WebInspectorUI/ChangeLog:11
> +        * UserInterface/External/Esprima/esprima.js: File updated, no changes made.

This says "no changes made", yet there are lots and lots of changes. In fact the version went from 1.2.2 to 2.0.0-dev:

    - exports.version = '1.2.2';
    + exports.version = '2.0.0-dev';

Was this intentional? Are there compatibility differences between the versions that we will need to address?

[Jonathan Wells]

Created attachment 241324 [details]
[PATCH] Correct esprima version

Pulled incorrect tag before. Here is the correct version: 1.2.2.

[Jonathan Wells]

Created attachment 241325 [details]
[PATCH] Correct esprima version.

[WebKit Commit Bot]

Comment on attachment 241325 [details]
[PATCH] Correct esprima version.

Clearing flags on attachment: 241325

Committed r175850: <http://trac.webkit.org/changeset/175850>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.