Bug 138577 - th { text-align: inherit; } is not respected
Summary: th { text-align: inherit; } is not respected
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Minor
Assignee: Nobody
Keywords: HasReduction, InRadar
Depends on:
Reported: 2014-11-10 13:56 PST by Anthony Ryan
Modified: 2022-06-16 19:47 PDT (History)
7 users (show)

See Also:


Note You need to log in before you can comment on or make changes to this bug.
Description Anthony Ryan 2014-11-10 13:56:28 PST
Example URL:

The expected behavior when using text-align: inherit; on a th is to inherit the text alignment of a parent element, in the case of my example left. Rather than doing this Safari uses the useragent default for th which is text-align: center.

Verified in Safari 8 and the latest WebKit Nightly build.

Other browsers:
Firefox 33: Working as expected
Internet Explorer 11: Working as expected
Chrome 39: Also broken.
Comment 1 Anthony Ryan 2014-11-10 13:56:56 PST
Chromium bug for cross-reference:
Comment 2 Anthony Ryan 2016-04-18 01:17:00 PDT
The Chromium patch to resolve this bug, for cross-reference: https://chromium.googlesource.com/chromium/src.git/+/367b26a9cdb1389d3e16c30527742f7cd33ef74d
Comment 3 Radar WebKit Bug Importer 2022-06-02 01:09:08 PDT
Comment 4 Karl Dubost 2022-06-02 01:14:16 PDT
This issue forced Bootstrap to use `-webkit-match-parent` on their CSS

which in return makes it hard to remove it from the Web platform without breaking Safari. 

If it is being fixed it will help to obsolete it, and convince BootStrap to remove it too. 

The WPT has already a test to remove the support of `-webkit-match-parent`
Comment 5 Karl Dubost 2022-06-02 02:20:30 PDT
Filed https://github.com/whatwg/html/issues/7978

because the spec says Safari does the right thing. 
but Firefox and Chrome do differently.

Comment 6 Tim Nguyen (:ntim) 2022-06-02 13:13:46 PDT
This is the relevant bit in WebKit:

I personally haven't tested which approach works, but the 2 I have in mind are:

1. Add a applyInheritTextAlign function here: https://webkit-search.igalia.com/webkit/rev/26eff7cbe4e53bbd8b325ee12a3567128ba52d2e/Source/WebCore/style/StyleBuilderCustom.h#197-207 that sets both textAlign, but also hasExplicitlySetTextAlign(). This needs to change: https://webkit-search.igalia.com/webkit/rev/26eff7cbe4e53bbd8b325ee12a3567128ba52d2e/Source/WebCore/css/CSSProperties.json#4590 to "custom": "All" in order to work.

2. Remove the StyleAdjuster code, do like Firefox/Chrome and add an `-internal-center-or-inherit` value, implement it in https://webkit-search.igalia.com/webkit/rev/26eff7cbe4e53bbd8b325ee12a3567128ba52d2e/Source/WebCore/style/StyleBuilderConverter.h#609 , something like:

if (primitiveValue.valueID() == CSSValueInternalCenterOrInherit)
  if (parentStyle.textAlign() != TextAlign::Start)
     return parentStyle.textAlign();
  return TextAlign::Center;
Comment 7 Ryan Reno 2022-06-14 09:38:07 PDT
Pull request: https://github.com/WebKit/WebKit/pull/1503
Comment 8 Ryan Reno 2022-06-14 16:13:12 PDT
Last PR ended up breaking some WPT tests for `all: revert`. I'm going to go for Tim's #2 suggestion and use an internal CSS property instead.
Comment 9 Ryan Reno 2022-06-15 19:43:50 PDT
Pull request: https://github.com/WebKit/WebKit/pull/1568
Comment 10 EWS 2022-06-16 19:47:52 PDT
Committed r295625 (251630@main): <https://commits.webkit.org/251630@main>

Reviewed commits have been landed. Closing PR #1568 and removing active labels.