Bug 138553 - [EFL] Remove GamepadDeviceEfl::create()
Summary: [EFL] Remove GamepadDeviceEfl::create()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-11-09 19:00 PST by Gyuyoung Kim
Modified: 2014-11-09 22:52 PST (History)
2 users (show)

See Also:

Attachments
Patch (3.29 KB, patch)
2014-11-09 19:01 PST, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Patch (3.56 KB, patch)
2014-11-09 21:49 PST, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Patch for landing (3.55 KB, patch)
2014-11-09 22:06 PST, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2014-11-09 19:00:16 PST 
SSIA
Comment 1 Gyuyoung Kim 2014-11-09 19:01:24 PST 
Created attachment 241269 [details]
Patch
Comment 2 Gyuyoung Kim 2014-11-09 21:49:15 PST 
Created attachment 241274 [details]
Patch
Comment 3 Darin Adler 2014-11-09 21:50:20 PST 
Comment on attachment 241274 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=241274&action=review

> Source/WebCore/platform/efl/GamepadsEfl.cpp:122
> +    Vector<std::unique_ptr<GamepadDeviceEfl> > m_slots;

No need for the space between the two > characters here.
Comment 4 Gyuyoung Kim 2014-11-09 22:06:24 PST 
Created attachment 241276 [details]
Patch for landing
Comment 5 Gyuyoung Kim 2014-11-09 22:12:10 PST 
(In reply to comment #3)
> Comment on attachment 241274 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=241274&action=review
> 
> > Source/WebCore/platform/efl/GamepadsEfl.cpp:122
> > +    Vector<std::unique_ptr<GamepadDeviceEfl> > m_slots;
> 
> No need for the space between the two > characters here.

Ok, removed it.
Comment 6 WebKit Commit Bot 2014-11-09 22:52:33 PST 
Comment on attachment 241276 [details]
Patch for landing

Clearing flags on attachment: 241276

Committed r175800: <http://trac.webkit.org/changeset/175800>
Comment 7 WebKit Commit Bot 2014-11-09 22:52:36 PST 
All reviewed patches have been landed.  Closing bug.