Bug 138530 - Context menus should not offer the "Download video" option for videos that cannot be downloaded
Summary: Context menus should not offer the "Download video" option for videos that ca...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
: 138734 (view as bug list)
Depends on:
Blocks:
 
Reported: 2014-11-07 17:34 PST by Beth Dakin
Modified: 2014-11-14 02:46 PST (History)
7 users (show)

See Also:

Attachments
WIP patch (13.84 KB, patch)
2014-11-13 07:36 PST, Eric Carlson 		no flags Details | Formatted Diff | Diff
Patch (17.92 KB, patch)
2014-11-13 16:18 PST, Beth Dakin 		thorton: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Beth Dakin 2014-11-07 17:34:29 PST 
Context menus should not offer the "Download video" option for videos that cannot be downloaded
Comment 1 Radar WebKit Bug Importer 2014-11-08 10:52:24 PST 
<rdar://problem/18919130>
Comment 2 Eric Carlson 2014-11-13 07:36:25 PST 
Created attachment 241484 [details]
WIP patch
Comment 3 Beth Dakin 2014-11-13 16:18:18 PST 
Created attachment 241517 [details]
Patch

I took over this patch from Eric. Eric wanted to write a test, but I don't think it is possible to capture this with a layout test. oncontextmenu will allow you to override the context menu action, but it doesn't let you see what is in the default menu. 

I also made one small change that should keep GTK building.
Comment 4 Beth Dakin 2014-11-13 16:49:34 PST 
Thanks Tim! http://trac.webkit.org/changeset/176108
Comment 5 Éva Balázsfalvi 2014-11-14 02:46:18 PST 
*** Bug 138734 has been marked as a duplicate of this bug. ***