Bug 138528 - Delete cookies between tests
Summary: Delete cookies between tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-11-07 17:15 PST by Alexey Proskuryakov
Modified: 2014-11-08 19:17 PST (History)
3 users (show)

See Also:

Attachments
proposed fix (5.30 KB, patch)
2014-11-07 17:19 PST, Alexey Proskuryakov 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2014-11-07 17:15:37 PST 
We should start each test from a clean state, so that there is never a dependency on test order.

Most of the time, tests clean up after themselves, and they should continue doing this so that they could be run from a browser. But it's been too often that leaking cookies caused test flakiness, it's time to stop that for good.
Comment 1 Alexey Proskuryakov 2014-11-07 17:19:43 PST 
Created attachment 241221 [details]
proposed fix
Comment 2 WebKit Commit Bot 2014-11-08 19:17:07 PST 
Comment on attachment 241221 [details]
proposed fix

Clearing flags on attachment: 241221

Committed r175783: <http://trac.webkit.org/changeset/175783>
Comment 3 WebKit Commit Bot 2014-11-08 19:17:18 PST 
All reviewed patches have been landed.  Closing bug.