WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
138526
Directional single quotation marks are not rotated in vertical text
https://bugs.webkit.org/show_bug.cgi?id=138526
Summary
Directional single quotation marks are not rotated in vertical text
Myles C. Maxfield
Reported
2014-11-07 16:09:39 PST
Directional single quotation marks are not rotated in vertical text
Attachments
Patch
(3.71 KB, patch)
2014-11-07 16:10 PST
,
Myles C. Maxfield
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1
2014-11-07 16:10:56 PST
Created
attachment 241217
[details]
Patch
Myles C. Maxfield
Comment 2
2014-11-07 16:11:50 PST
<
rdar://problem/14393598
>
Darin Adler
Comment 3
2014-11-08 13:39:31 PST
Comment on
attachment 241217
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=241217&action=review
> Source/WebCore/platform/graphics/FontGlyphs.cpp:149 > + if (character == 0x02016 || character == 0x02020 || character == 0x02021 || character == 0x2030 || character == 0x02031) > return true;
Strange that we write 0x2030 and not 0x02030 here given the rest of the surrounding code. This entire function has a coding style that is not great. A whole long data table written out as separate function calls, with no rationale given for the choices of the values or even a summary at the top. Did this come from some table in some specification? Does ICU have a function for this, and if so, why aren’t we using that?
Myles C. Maxfield
Comment 4
2014-11-09 08:05:44 PST
Comment on
attachment 241217
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=241217&action=review
>> Source/WebCore/platform/graphics/FontGlyphs.cpp:149 >> return true; > > Strange that we write 0x2030 and not 0x02030 here given the rest of the surrounding code. > > This entire function has a coding style that is not great. A whole long data table written out as separate function calls, with no rationale given for the choices of the values or even a summary at the top. Did this come from some table in some specification? Does ICU have a function for this, and if so, why aren’t we using that?
Yes:
http://www.unicode.org/reports/tr50/tr50-6.Orientation.txt
The numbers in this function originally came from a giant switch statement; I'm guessing the leading 0s existed to make the case statements right-aligned. I looked for an ICU function, but couldn't find one. I emailed Kida-san last week to ask if he knows of one.
WebKit Commit Bot
Comment 5
2014-12-05 21:13:41 PST
Comment on
attachment 241217
[details]
Patch Clearing flags on attachment: 241217 Committed
r176903
: <
http://trac.webkit.org/changeset/176903
>
WebKit Commit Bot
Comment 6
2014-12-05 21:13:47 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug