Bug 138526 – Directional single quotation marks are not rotated in vertical text

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Myles C. Maxfield]

Directional single quotation marks are not rotated in vertical text

[Myles C. Maxfield]

Created attachment 241217 [details]
Patch

[Myles C. Maxfield]

<rdar://problem/14393598>

[Darin Adler]

Comment on attachment 241217 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=241217&action=review

> Source/WebCore/platform/graphics/FontGlyphs.cpp:149
> +    if (character == 0x02016 || character == 0x02020 || character == 0x02021 || character == 0x2030 || character == 0x02031)
>          return true;

Strange that we write 0x2030 and not 0x02030 here given the rest of the surrounding code.

This entire function has a coding style that is not great. A whole long data table written out as separate function calls, with no rationale given for the choices of the values or even a summary at the top. Did this come from some table in some specification? Does ICU have a function for this, and if so, why aren’t we using that?

[Myles C. Maxfield]

Comment on attachment 241217 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=241217&action=review

>> Source/WebCore/platform/graphics/FontGlyphs.cpp:149
>>          return true;
> 
> Strange that we write 0x2030 and not 0x02030 here given the rest of the surrounding code.
> 
> This entire function has a coding style that is not great. A whole long data table written out as separate function calls, with no rationale given for the choices of the values or even a summary at the top. Did this come from some table in some specification? Does ICU have a function for this, and if so, why aren’t we using that?

Yes: http://www.unicode.org/reports/tr50/tr50-6.Orientation.txt

The numbers in this function originally came from a giant switch statement; I'm guessing the leading 0s existed to make the case statements right-aligned.

I looked for an ICU function, but couldn't find one. I emailed Kida-san last week to ask if he knows of one.

[WebKit Commit Bot]

Comment on attachment 241217 [details]
Patch

Clearing flags on attachment: 241217

Committed r176903: <http://trac.webkit.org/changeset/176903>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.