Bug 138522 – [iOS] video is sometimes allowed to play from the background

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Eric Carlson]

Allow video to play when Safari is in the background in some situations.

[Eric Carlson]

<rdar://problem/18878671>

[Eric Carlson]

Created attachment 241213 [details]
Proposed patch.

[Jer Noble]

Comment on attachment 241213 [details]
Proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=241213&action=review

> Source/WebCore/ChangeLog:8
> +        Reviewed by NOBODY (OOPS!).
> +
> +        * html/HTMLMediaElement.cpp:

What is actually broken and why does this patch fix it?

> Source/WebCore/platform/audio/MediaSession.cpp:-192
> -    if (m_clientDataBufferingTimer.isActive())
> -        m_clientDataBufferingTimer.stop();
> -

Perhaps an ASSERT(!m_clientDataBufferingTimer.isActive()) ?

[Eric Carlson]

Created attachment 241223 [details]
Revised patch

[WebKit Commit Bot]

Attachment 241223 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Eric Carlson]

Created attachment 241228 [details]
Updated patch

[Jer Noble]

Comment on attachment 241228 [details]
Updated patch

View in context: https://bugs.webkit.org/attachment.cgi?id=241228&action=review

R=me with minor nits.

> Source/WebCore/html/HTMLMediaElement.cpp:5988
> +    ASSERT_NOT_REACHED();

This could be a "default:" case.

> Source/WebCore/platform/audio/MediaSession.h:108
> +        Optimized

Nit: a comma here would make future duffs nicer.

[Eric Carlson]

Created attachment 241229 [details]
Patch for landing.

[Eric Carlson]

Committed r175777: https://trac.webkit.org/r175777

[Eric Carlson]

Committed https://trac.webkit.org/r175981 as a follow up.