Bug 138505 - Crash playing DASH video
Summary: Crash playing DASH video
Status: RESOLVED DUPLICATE of bug 137065
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-11-07 07:58 PST by Xavier Claessens
Modified: 2014-11-07 11:30 PST (History)
0 users

See Also:

Attachments
Relevant valgrind trace (4.97 KB, text/plain)
2014-11-07 07:58 PST, Xavier Claessens 		no flags Details
Proposed patch (4.36 KB, patch)
2014-11-07 07:59 PST, Xavier Claessens 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Xavier Claessens 2014-11-07 07:58:17 PST 
Created attachment 241180 [details]
Relevant valgrind trace

Webkit2 sometimes crash when playing that video: http://demo.unified-streaming.com/video/smurfs/smurfs.ism/smurfs.mpd?format=mp4

The crash happens when DASH decides to change the video's resolution (it's adaptative). When gstreamer sends caps it means that the NEXT buffer will have that new resolution, but a race can occure and webkit will use that new caps for the PREVIOUS buffer. That lead to a crash because the resolution (thus buffer size) mismatch.
Comment 1 Xavier Claessens 2014-11-07 07:59:59 PST 
Created attachment 241182 [details]
Proposed patch

This patch makes sure we always use the GstCaps that goes with the GstBuffer.
Comment 2 Xavier Claessens 2014-11-07 11:30:25 PST 
Oops, already fixed.

*** This bug has been marked as a duplicate of bug 137065 ***