Bug 138490 - Make it possible to associate snapshots with back/forward list items other than the current item
Summary: Make it possible to associate snapshots with back/forward list items other th...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-11-06 19:18 PST by Anshu Chimala
Modified: 2014-11-07 12:35 PST (History)
4 users (show)

See Also:

Attachments
Patch (6.74 KB, patch)
2014-11-07 11:12 PST, Anshu Chimala 		no flags Details | Formatted Diff | Diff
New patch because I missed an UNUSED_PARAM. :( (6.75 KB, patch)
2014-11-07 11:52 PST, Anshu Chimala 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anshu Chimala 2014-11-06 19:18:54 PST 
Currently, WKViews can only save snapshots associated with the current back/forward list item. We should extend this to allow snapshots to be associated with any item in the list.

<rdar://problem/18901802>
Comment 1 Anshu Chimala 2014-11-07 11:12:03 PST 
Created attachment 241194 [details]
Patch
Comment 2 Tim Horton 2014-11-07 11:39:25 PST 
Looks reasonable to me! Thanks for the patch :)
Comment 3 Anshu Chimala 2014-11-07 11:52:58 PST 
Created attachment 241197 [details]
New patch because I missed an UNUSED_PARAM. :(
Comment 4 WebKit Commit Bot 2014-11-07 12:35:23 PST 
Comment on attachment 241197 [details]
New patch because I missed an UNUSED_PARAM. :(

Clearing flags on attachment: 241197

Committed r175759: <http://trac.webkit.org/changeset/175759>
Comment 5 WebKit Commit Bot 2014-11-07 12:35:25 PST 
All reviewed patches have been landed.  Closing bug.