Bug 138485 – Remove useless if check in HTMLInputElement::setValue()

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Chris Dumez]

Remove useless if check in HTMLInputElement::setValue().

[Chris Dumez]

Created attachment 241144 [details]
Patch

[Daniel Bates]

Comment on attachment 241144 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=241144&action=review

> Source/WebCore/html/HTMLInputElement.cpp:-963
> -
> -    if (!valueChanged)
> -        return;

It looks like this code was inadvertently left in the patch for bug #67742 (http://trac.﷒0﷓), which moved the logic for dispatching change events among other changes from class HTMLInputElement to class InputType or classes that extend InputType.

For completeness, this code was originally added in the patch for bug #63092 (http://trac.webkit.org/changeset/89624).

[Daniel Bates]

Comment on attachment 241144 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=241144&action=review

> Source/WebCore/ChangeLog:9
> +        Remove useless if check in HTMLInputElement::setValue(), probably left
> +        out after earlier refactoring.

For your consideration, I suggest adding a remark that this code was inadvertently left in as part of the patch for bug #67742 (http://trac.webkit.org/changeset/94836). If you feel this is unnecessary then feel free to cq+ this patch.

[Chris Dumez]

Created attachment 241155 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 241155 [details]
Patch

Clearing flags on attachment: 241155

Committed r175742: <http://trac.webkit.org/changeset/175742>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.