Bug 138479 - Drop useless HTMLElement::isURLAttribute() override
Summary: Drop useless HTMLElement::isURLAttribute() override
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-11-06 15:17 PST by Chris Dumez
Modified: 2014-11-07 10:28 PST (History)
6 users (show)

See Also:


Attachments
Patch (2.11 KB, patch)
2014-11-06 15:19 PST, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (2.11 KB, patch)
2014-11-07 09:42 PST, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2014-11-06 15:17:21 PST
Drop useless HTMLElement::isURLAttribute() override as it is doing nothing but call the parent class' isURLAttribute().
Comment 1 Chris Dumez 2014-11-06 15:19:24 PST
Created attachment 241134 [details]
Patch
Comment 2 Mark Lam 2014-11-07 01:37:24 PST
Comment on attachment 241134 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=241134&action=review

r=me with comment fix.

> Source/WebCore/ChangeLog:9
> +        nothing but call the parent class' isURLAttribute().

typo: /call/calling/
Comment 3 Chris Dumez 2014-11-07 09:42:13 PST
Created attachment 241188 [details]
Patch
Comment 4 WebKit Commit Bot 2014-11-07 10:28:37 PST
Comment on attachment 241188 [details]
Patch

Clearing flags on attachment: 241188

Committed r175752: <http://trac.webkit.org/changeset/175752>
Comment 5 WebKit Commit Bot 2014-11-07 10:28:42 PST
All reviewed patches have been landed.  Closing bug.