138475 – Remove code that prepends a leading 'r' to the first argument of _run_git_svn_find_rev in git.py

RESOLVED FIXED 138475

Remove code that prepends a leading 'r' to the first argument of _run_git_svn_find_rev in git.py

https://bugs.webkit.org/show_bug.cgi?id=138475

Summary Remove code that prepends a leading 'r' to the first argument of _run_git_svn...

Matthew Hanson

Reported 2014-11-06 14:04:46 PST

This code breaks compatibility with the svn_revision_from_git_commit method. Once it is removed, it is up to the caller of _run_git_svn_find_rev to ensure that its revision is prepended with an 'r', when calling _run_git_svn_find_rev with an SVN revision.

Attachments
Patch (2.83 KB, patch) 2014-11-06 14:07 PST, Matthew Hanson	rniwa: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Matthew Hanson

Comment 1 2014-11-06 14:07:16 PST

Created attachment 241132 [details] Patch

Matthew Hanson

Comment 2 2014-11-06 14:41:26 PST

Committed r175717: <http://trac.webkit.org/changeset/175717>

Note You need to log in before you can comment on or make changes to this bug.

Status RESOLVED

Resolution FIXED

Priority P2

Severity Normal

Classification Unclassified

Version 528+ (Nightly build)

Hardware Unspecified

OS Unspecified

Product WebKit

Component Tools / Tests

Assignee

Nobody

Reported

2014-11-06 14:04 PST

Modified

2014-11-06 14:41 PST History

CC List

5 users Show

URL

Keywords

Depends on

Blocks