Bug 138475 - Remove code that prepends a leading 'r' to the first argument of _run_git_svn_find_rev in git.py
Summary: Remove code that prepends a leading 'r' to the first argument of _run_git_svn...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-11-06 14:04 PST by Matthew Hanson
Modified: 2014-11-06 14:41 PST (History)
5 users (show)

See Also:

Attachments
Patch (2.83 KB, patch)
2014-11-06 14:07 PST, Matthew Hanson 		rniwa: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matthew Hanson 2014-11-06 14:04:46 PST 
This code breaks compatibility with the svn_revision_from_git_commit method. Once it is removed, it is up to the caller of _run_git_svn_find_rev to ensure that its revision is prepended with an 'r', when calling _run_git_svn_find_rev with an SVN revision.
Comment 1 Matthew Hanson 2014-11-06 14:07:16 PST 
Created attachment 241132 [details]
Patch
Comment 2 Matthew Hanson 2014-11-06 14:41:26 PST 
Committed r175717: <http://trac.webkit.org/changeset/175717>