Bug 138470 - Add test for fix of REGRESSION (r174985-174986): Site display disappears
Summary: Add test for fix of REGRESSION (r174985-174986): Site display disappears
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-11-06 11:48 PST by Michael Saboff
Modified: 2014-11-10 15:23 PST (History)
0 users

See Also:

Attachments
Patch (2.41 KB, patch)
2014-11-10 15:15 PST, Michael Saboff 		ggaren: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2014-11-06 11:48:59 PST 
The patch was landed before a test was created.
Comment 1 Michael Saboff 2014-11-10 15:15:46 PST 
Created attachment 241312 [details]
Patch
Comment 2 Geoffrey Garen 2014-11-10 15:17:28 PST 
Comment on attachment 241312 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=241312&action=review

r=me

> LayoutTests/js/dom/document-write-functions-cached.html:18
> +if (document.writeln === document.writeln)
> +    debug("PASS: document.write is cached.");
> +else
> +    debug("FAIL: document.write is not cached, but should be.");

Message should be writeln, not write.
Comment 3 Michael Saboff 2014-11-10 15:23:17 PST 
(In reply to comment #2)
> Comment on attachment 241312 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=241312&action=review
> 
> r=me
> 
> > LayoutTests/js/dom/document-write-functions-cached.html:18
> > +if (document.writeln === document.writeln)
> > +    debug("PASS: document.write is cached.");
> > +else
> > +    debug("FAIL: document.write is not cached, but should be.");
> 
> Message should be writeln, not write.

Fixed.
Comment 4 Michael Saboff 2014-11-10 15:23:50 PST 
Committed r175834: <http://trac.webkit.org/changeset/175834>