RESOLVED FIXED 138444
Page preview popover should show scaled-down web content 
https://bugs.webkit.org/show_bug.cgi?id=138444
Summary Page preview popover should show scaled-down web content
Beth Dakin
Reported 2014-11-05 15:16:25 PST
Page preview popover should show scaled-down web content rdar://problem/18887140
Attachments
Patch (3.97 KB, patch)
2014-11-05 15:20 PST, Beth Dakin 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Beth Dakin
Comment 1 2014-11-05 15:20:48 PST
Created attachment 241062 [details] Patch
Tim Horton
Comment 2 2014-11-05 15:22:24 PST
Comment on attachment 241062 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=241062&action=review > Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:63 > +static const CGFloat preferredPopoverToWKViewScale = 0.75; It's not a WKView :)
Anders Carlsson
Comment 3 2014-11-05 15:27:23 PST
Comment on attachment 241062 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=241062&action=review >> Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:63 >> +static const CGFloat preferredPopoverToWKViewScale = 0.75; > > It's not a WKView :) Nor preferred :) > Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:110 > + [webView setBounds:NSMakeRect(0, 0, _mainViewSize.width / preferredPopoverToWKViewScale, _mainViewSize.height / preferredPopoverToWKViewScale)]; This could probably use a comment.
Beth Dakin
Comment 4 2014-11-05 15:32:06 PST
Thanks! http://trac.webkit.org/changeset/175645
Tim Horton
Comment 5 2014-11-05 16:19:46 PST
Build fix in http://trac.webkit.org/changeset/175649
Note You need to log in before you can comment on or make changes to this bug.