Bug 138444 - Page preview popover should show scaled-down web content
Summary: Page preview popover should show scaled-down web content
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-11-05 15:16 PST by Beth Dakin
Modified: 2014-11-05 16:19 PST (History)
4 users (show)

See Also:

Attachments
Patch (3.97 KB, patch)
2014-11-05 15:20 PST, Beth Dakin 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Beth Dakin 2014-11-05 15:16:25 PST 
Page preview popover should show scaled-down web content

rdar://problem/18887140
Comment 1 Beth Dakin 2014-11-05 15:20:48 PST 
Created attachment 241062 [details]
Patch
Comment 2 Tim Horton 2014-11-05 15:22:24 PST 
Comment on attachment 241062 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=241062&action=review

> Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:63
> +static const CGFloat preferredPopoverToWKViewScale = 0.75;

It's not a WKView :)
Comment 3 Anders Carlsson 2014-11-05 15:27:23 PST 
Comment on attachment 241062 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=241062&action=review

>> Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:63
>> +static const CGFloat preferredPopoverToWKViewScale = 0.75;
> 
> It's not a WKView :)

Nor preferred :)

> Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:110
> +    [webView setBounds:NSMakeRect(0, 0, _mainViewSize.width / preferredPopoverToWKViewScale, _mainViewSize.height / preferredPopoverToWKViewScale)];

This could probably use a comment.
Comment 4 Beth Dakin 2014-11-05 15:32:06 PST 
Thanks! http://trac.webkit.org/changeset/175645
Comment 5 Tim Horton 2014-11-05 16:19:46 PST 
Build fix in http://trac.webkit.org/changeset/175649