Bug 138428 – [GTK] Run layout tests using the network process

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Carlos Garcia Campos]

Shared secondary process is the default in the GTK+ port, but we should run the tests using the network process to ensure everything works with the network process. In the future, the shared secondary process model might be a special case of multiple processes with 1 as maximum number of processes, but always using the network process.

[Carlos Garcia Campos]

Created attachment 241031 [details]
Patch

[Carlos Garcia Campos]

Committed r175690: <http://trac.webkit.org/changeset/175690>

[WebKit Commit Bot]

Re-opened since this is blocked by bug 138460

[Carlos Garcia Campos]

Let's try again now :-)

[Carlos Garcia Campos]

Committed r175776: <http://trac.webkit.org/changeset/175776>

[Carlos Garcia Campos]

Ok, no more crashes, but there are still some more failures, most of them are http tests. I'll look at those in detail and will try to fix them without rolling this out again.

[Carlos Alberto Lopez Perez]

(In reply to comment #6)
> Ok, no more crashes, but there are still some more failures, most of them
> are http tests. I'll look at those in detail and will try to fix them
> without rolling this out again.

This (r175776) has caused +60 new failures: 

r175775 -> https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20%28Tests%29/builds/4067

r175776 -> https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20%28Tests%29/builds/4064

[Alexey Proskuryakov]

One big reason for these failures is that shared workers are disabled in multiple web process mode.

Another one that I'm particularly interested in is http/tests/xmlhttprequest/cross-origin-cookie-storage.html. It looks like I independently broke this test on Mac a few revisions later. We'll need to see what's going on there.

[Alexey Proskuryakov]

> Another one that I'm particularly interested in is
> http/tests/xmlhttprequest/cross-origin-cookie-storage.html.

Turns out that it's simply because testRunner.setAlwaysAcceptCookies is not implemented with NetworkProcess. The test used to pass on Mac by mistake, due to having a cookie leak from a previous test.

I disabled it on Mac.

[Carlos Garcia Campos]

(In reply to comment #7)
> (In reply to comment #6)
> > Ok, no more crashes, but there are still some more failures, most of them
> > are http tests. I'll look at those in detail and will try to fix them
> > without rolling this out again.
> 
> This (r175776) has caused +60 new failures: 

I know, and I said that I'll look at those in detail and I'll try to fix them without rolling it out. If I can't figure out how to fix the failures, I'll roll this out, don't worry.

> r175775 ->
> https://build.webkit.org/builders/GTK%20Linux%2064-
> bit%20Release%20%28Tests%29/builds/4067
> 
> r175776 ->
> https://build.webkit.org/builders/GTK%20Linux%2064-
> bit%20Release%20%28Tests%29/builds/4064

[Carlos Garcia Campos]

(In reply to comment #8)
> One big reason for these failures is that shared workers are disabled in
> multiple web process mode.

Thanks, I've just skipped the shared workers tests in r176019