Bug 138423 – AX: Improve AccessibilityTableCell isColumnHeaderCell function.

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Andrzej Badowski]

The error in this function has been detected, when it turned out that the direct placement of <tr> tag to the <table> tage is changed in the browser. Namely, the resulting html code viewed by Inspector shows that between the <table> tag and the <tr> tag has been added <tbody> tag. Examples of browsers include: Mozilla, Chromium, Opera, Safari, MiniBrowser EFL. Function should take into account the behavior of browsers.

[Radar WebKit Bug Importer]

<rdar://problem/18888643>

[Andrzej Badowski]

Created attachment 241111 [details]
proposed patch

[chris fleizach]

Comment on attachment 241111 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=241111&action=review

> Source/WebCore/ChangeLog:10
> +        New tests are not necessary.

how come no new tests are necessary?

[Andrzej Badowski]

Comment on attachment 241111 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=241111&action=review

>> Source/WebCore/ChangeLog:10
>> +        New tests are not necessary.
> 
> how come no new tests are necessary?

Existing tests: table-cells-roles.html, table-cells.html have improved -expected files. In these files are visible positive changes. Eg. For the test table-cells-roles. So far, according to the logic of two functions: isColumnHeaderCell and isRowHeaderCell, cell (2,0), while in tbody 0 row, shows the role of AXCell. After correcting, this cell in row 0 will be assigned the role of AXColumnHeader. Similarly, in the test table-cells.

[WebKit Commit Bot]

Comment on attachment 241111 [details]
proposed patch

Clearing flags on attachment: 241111

Committed r176122: <http://trac.webkit.org/changeset/176122>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.