Bug 138421 - [WinCairo] Compile error, missing guard.
Summary: [WinCairo] Compile error, missing guard.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 138170
Blocks:
  Show dependency tree / graph
 
Reported: 2014-11-05 06:46 PST by peavo
Modified: 2014-11-05 15:04 PST (History)
5 users (show)

See Also:

Attachments
Patch (1.47 KB, patch)
2014-11-05 06:50 PST, peavo 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description peavo 2014-11-05 06:46:10 PST 
There is missing a guard for CSS_SELECTORS_LEVEL4 in CSSParserValues.cpp.
Comment 1 peavo 2014-11-05 06:50:02 PST 
Created attachment 241026 [details]
Patch
Comment 2 Brent Fulgham 2014-11-05 08:52:55 PST 
Comment on attachment 241026 [details]
Patch

r=me. Thank you for fixing this!
Comment 3 Brent Fulgham 2014-11-05 08:54:28 PST 
This bug was introduced in <http://trac.webkit.org/changeset/175446>.
Comment 4 WebKit Commit Bot 2014-11-05 09:35:12 PST 
Comment on attachment 241026 [details]
Patch

Clearing flags on attachment: 241026

Committed r175621: <http://trac.webkit.org/changeset/175621>
Comment 5 WebKit Commit Bot 2014-11-05 09:35:15 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 peavo 2014-11-05 11:00:24 PST 
(In reply to comment #2)
> Comment on attachment 241026 [details]
> Patch
> 
> r=me. Thank you for fixing this!

Thanks for reviewing :)
Comment 7 Dhi Aurrahman 2014-11-05 15:04:37 PST 
Thank you for fixing this. My bad.