Bug 138418 - NetscapePlugin: NPP_GetValue should receive a pointer to NPBool, not bool
Summary: NetscapePlugin: NPP_GetValue should receive a pointer to NPBool, not bool
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-11-05 05:20 PST by Alberto Garcia
Modified: 2014-11-05 05:29 PST (History)
0 users

See Also:


Attachments
Patch (1.35 KB, patch)
2014-11-05 05:22 PST, Alberto Garcia
cgarcia: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alberto Garcia 2014-11-05 05:20:51 PST
In NetscapePlugin::platformPostInitialize() we're calling NPP_GetValue(NPPVpluginNeedsXEmbed, &needsXEmbed) but needsXEmbed has the wrong type.
Comment 1 Alberto Garcia 2014-11-05 05:22:20 PST
Created attachment 241024 [details]
Patch
Comment 2 Alberto Garcia 2014-11-05 05:29:22 PST
Committed r175619: <http://trac.webkit.org/changeset/175619>