Bug 138416 - Fix the debug build after r175525
Summary: Fix the debug build after r175525
Status: RESOLVED DUPLICATE of bug 138407
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Csaba Osztrogonác
URL:
Keywords:
Depends on:
Blocks: 137942
  Show dependency tree / graph
 
Reported: 2014-11-05 03:43 PST by Csaba Osztrogonác
Modified: 2014-11-05 09:04 PST (History)
11 users (show)

See Also:

Attachments
Patch (1.50 KB, patch)
2014-11-05 03:46 PST, Csaba Osztrogonác 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2014-11-05 03:43:53 PST 
../../Source/WebCore/svg/SVGMarkerElement.cpp: In member function 'WebCore::SVGMarkerOrientType& WebCore::SVGMarkerElement::orientType() const':
../../Source/WebCore/svg/SVGMarkerElement.cpp:256:51: error: comparison of unsigned expression >= 0 is always true [-Werror=type-limits]
cc1plus: all warnings being treated as errors

line256: ASSERT(wrapper->currentAnimatedValue() >= 0 && wrapper->currentAnimatedValue() < SVGMarkerOrientMax);

wrapper->currentAnimatedValue() is unsigned, so it is always true, I think we should simple remove it.
Comment 1 Csaba Osztrogonác 2014-11-05 03:46:22 PST 
Created attachment 241023 [details]
Patch
Comment 2 Csaba Osztrogonác 2014-11-05 04:09:50 PST 

*** This bug has been marked as a duplicate of bug 138414 ***
Comment 3 Darin Adler 2014-11-05 09:04:26 PST 

*** This bug has been marked as a duplicate of bug 138407 ***