Bug 138413 - Add cache coders
Summary: Add cache coders
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 30322
  Show dependency tree / graph
 
Reported: 2014-11-05 02:48 PST by Antti Koivisto
Modified: 2014-11-07 05:08 PST (History)
5 users (show)

See Also:

Attachments
patch (45.68 KB, patch)
2014-11-05 03:01 PST, Antti Koivisto 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2014-11-05 02:48:02 PST 
Based on the IPC coders
Comment 1 Antti Koivisto 2014-11-05 03:01:15 PST 
Created attachment 241016 [details]
patch
Comment 2 WebKit Commit Bot 2014-11-05 03:03:32 PST 
Attachment 241016 [details] did not pass style-queue:


ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheEncoder.h:95:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheEncoder.h:96:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheEncoder.h:97:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheEncoder.h:98:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheEncoder.h:99:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheEncoder.h:100:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheEncoder.h:101:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheEncoder.h:102:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheEncoder.h:103:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheEncoder.h:104:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 10 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Carlos Garcia Campos 2014-11-05 03:21:21 PST 
Comment on attachment 241016 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=241016&action=review

> Source/WebKit2/NetworkProcess/cache/NetworkCacheCoders.cpp:163
> +    long long certificateSize;
> +    if (!decoder.decode(certificateSize))

This is long long, but there isn't a NetworkCacheDecoder::decode(long long&);
Comment 4 Anders Carlsson 2014-11-06 13:44:13 PST 
Comment on attachment 241016 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=241016&action=review

> Source/WebKit2/NetworkProcess/cache/NetworkCacheCoders.cpp:162
> +    long long certificateSize;

This should probably be int64_t.
Comment 5 Carlos Garcia Campos 2014-11-06 22:42:09 PST 
Comment on attachment 241016 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=241016&action=review

> Source/WebKit2/NetworkProcess/cache/NetworkCacheCoders.cpp:156
> +    encoder << static_cast<long long>(argumentEncoder.bufferSize());

And here too.
Comment 6 Antti Koivisto 2014-11-07 05:08:17 PST 
https://trac.webkit.org/r175748