RESOLVED FIXED 138408
Incorrect sandbox_check in RemoteInspector.mm 
https://bugs.webkit.org/show_bug.cgi?id=138408
Summary Incorrect sandbox_check in RemoteInspector.mm
Alexey Proskuryakov
Reported 2014-11-05 00:35:31 PST
1. There is no SANDBOX_CHECK_NO_REPORT, so I think that this still generates a sandbox violation. 2. In open source builds, the value of SANDBOX_FILTER_GLOBAL_NAME is incorrect - it should be 2, not 0. enum sandbox_filter_type { SANDBOX_FILTER_GLOBAL_NAME, };
Attachments
proposed fix (1.79 KB, patch)
2014-11-05 00:39 PST, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2014-11-05 00:35:54 PST
<rdar://problem/18878299>
Alexey Proskuryakov
Comment 2 2014-11-05 00:39:19 PST
Created attachment 241006 [details] proposed fix
WebKit Commit Bot
Comment 3 2014-11-05 00:42:02 PST
Attachment 241006 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/inspector/remote/RemoteInspector.mm:61: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Joseph Pecoraro
Comment 4 2014-11-05 11:08:26 PST
Comment on attachment 241006 [details] proposed fix r=me
WebKit Commit Bot
Comment 5 2014-11-05 11:57:22 PST
Comment on attachment 241006 [details] proposed fix Clearing flags on attachment: 241006 Committed r175629: <http://trac.webkit.org/changeset/175629>
WebKit Commit Bot
Comment 6 2014-11-05 11:57:25 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.