Bug 138408 - Incorrect sandbox_check in RemoteInspector.mm
Summary: Incorrect sandbox_check in RemoteInspector.mm
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
Keywords: InRadar
Depends on:
Reported: 2014-11-05 00:35 PST by Alexey Proskuryakov
Modified: 2014-11-05 11:57 PST (History)
7 users (show)

See Also:

proposed fix (1.79 KB, patch)
2014-11-05 00:39 PST, Alexey Proskuryakov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2014-11-05 00:35:31 PST
1. There is no SANDBOX_CHECK_NO_REPORT, so I think that this still generates a sandbox violation.
2. In open source builds, the value of SANDBOX_FILTER_GLOBAL_NAME is incorrect - it should be 2, not 0.

enum sandbox_filter_type {
Comment 1 Radar WebKit Bug Importer 2014-11-05 00:35:54 PST
Comment 2 Alexey Proskuryakov 2014-11-05 00:39:19 PST
Created attachment 241006 [details]
proposed fix
Comment 3 WebKit Commit Bot 2014-11-05 00:42:02 PST
Attachment 241006 [details] did not pass style-queue:

ERROR: Source/JavaScriptCore/inspector/remote/RemoteInspector.mm:61:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 1 in 2 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Joseph Pecoraro 2014-11-05 11:08:26 PST
Comment on attachment 241006 [details]
proposed fix

Comment 5 WebKit Commit Bot 2014-11-05 11:57:22 PST
Comment on attachment 241006 [details]
proposed fix

Clearing flags on attachment: 241006

Committed r175629: <http://trac.webkit.org/changeset/175629>
Comment 6 WebKit Commit Bot 2014-11-05 11:57:25 PST
All reviewed patches have been landed.  Closing bug.