We should stop special-casing the empty string in HTMLInputElement.type setter. Currently, if input.type is set to "", we will remove the type attribute. This is inconsistent with the spec and other browsers (tested Firefox 33 and Chrome 38). We should set the attribute to the empty string instead of removing it.
Created attachment 241002 [details] Patch
Comment on attachment 241002 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=241002&action=review > LayoutTests/fast/dom/HTMLInputElement/input-type-attribute.html:13 > +input.type = "button"; > +shouldBeEqualToString("input.type", "button"); We should do the assignment inside shouldBeEqualToString or in evalAndLog so that it's visible in the expected result.
Created attachment 241033 [details] Patch
Comment on attachment 241033 [details] Patch Clearing flags on attachment: 241033 Committed r175622: <http://trac.webkit.org/changeset/175622>
All reviewed patches have been landed. Closing bug.