Bug 138388 - Add bundle SPI allowing PageOverlay to customize the action menu
Summary: Add bundle SPI allowing PageOverlay to customize the action menu
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-11-04 17:25 PST by Tim Horton
Modified: 2014-11-04 17:40 PST (History)
6 users (show)

See Also:


Attachments
Patch (14.80 KB, patch)
2014-11-04 17:25 PST, Tim Horton
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2014-11-04 17:25:03 PST
Add bundle SPI allowing PageOverlay to customize the action menu
Comment 1 Tim Horton 2014-11-04 17:25:23 PST
Created attachment 240988 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2014-11-04 17:26:37 PST
<rdar://problem/18875579>
Comment 3 Anders Carlsson 2014-11-04 17:36:10 PST
Comment on attachment 240988 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240988&action=review

> Source/WebCore/page/PageOverlayController.h:52
> +    Vector<RefPtr<PageOverlay>>& pageOverlays() const { return m_pageOverlays; }

This should either return a const Vector& or not be const.

> Source/WebKit2/WebProcess/WebPage/WebPageOverlay.cpp:39
> +static HashMap<PageOverlay*, WebPageOverlay*>& coreOverlayMap()

I think this can just be called overlayMap().

> Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm:1205
> +    for (auto& overlay : mainFrame.pageOverlayController().pageOverlays()) {

I think this can be const auto&.
Comment 4 Tim Horton 2014-11-04 17:40:05 PST
http://trac.webkit.org/changeset/175597