Bug 138387 – Web Inspector: Lots of TimelineDataGridNode asserts on reloads

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Joseph Pecoraro]

* SUMMARY
Hundreds of of TimelineDataGridNode asserts reloading pages.

    console.assert(isFinite(secondsPerPixel) && secondsPerPixel > 0);

[Error] Assertion failed:
  refreshGraph (TimelineDataGridNode.js, line 240)
  updateLayout (OverviewTimelineView.js, line 110)
  updateLayoutIfNeeded (TimelineView.js, line 217)
  _updateTimes (TimelineContentView.js, line 367)
  _update (TimelineContentView.js, line 331)
  (anonymous function) ([native code], line 0)

* STEPS TO REPRODUCE
1. Inspect http://daringfireball.net
2. Ensure Resource sidebar is selected not Timelines. Close and reopen inspector if needed.
3. Reload page
  => hundreds of asserts

* NOTES
secondsPerPixel is 0.

[Radar WebKit Bug Importer]

<rdar://problem/18875354>

[Joseph Pecoraro]

Created attachment 240984 [details]
[PATCH] Proposed Fix

[Brian Burg]

Comment on attachment 240984 [details]
[PATCH] Proposed Fix

Another thought (maybe a different bug): why do we refresh the timeline ruler's layout when it's not visible? This seems like a lot of work for no reason.

[Joseph Pecoraro]

(In reply to comment #3)
> Comment on attachment 240984 [details]
> [PATCH] Proposed Fix
> 
> Another thought (maybe a different bug): why do we refresh the timeline
> ruler's layout when it's not visible? This seems like a lot of work for no
> reason.

Totally agree. I'll file a bug about that right now.

[WebKit Commit Bot]

Comment on attachment 240984 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 240984

Committed r175598: <http://trac.webkit.org/changeset/175598>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.