We should un-anchor or dismiss data detector popovers on scroll and at all of the other times that the dictionary lookup popover dismisses. rdar://problem/18869345
Created attachment 240978 [details] Pacth
Attachment 240978 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:10: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 240978 [details] Pacth View in context: https://bugs.webkit.org/attachment.cgi?id=240978&action=review > Source/WebKit2/UIProcess/PageClient.h:228 > + virtual void dismissActionMenuDataDetetcorPopovers() = 0; Detetcor > Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:167 > + // that and know whether or not it succeeded, so we'll settle for unachoring. unachoring
Thanks Tim! http://trac.webkit.org/changeset/175609
Build fix http://trac.webkit.org/changeset/175610