Bug 138385 - Un-anchor data detector popovers on scroll
Summary: Un-anchor data detector popovers on scroll
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2014-11-04 16:41 PST by Beth Dakin
Modified: 2014-11-04 21:52 PST (History)
3 users (show)

See Also:

Pacth (9.17 KB, patch)
2014-11-04 16:45 PST, Beth Dakin
thorton: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Beth Dakin 2014-11-04 16:41:18 PST
We should un-anchor or dismiss data detector popovers on scroll and at all of the other times that the dictionary lookup popover dismisses.

Comment 1 Beth Dakin 2014-11-04 16:45:16 PST
Created attachment 240978 [details]
Comment 2 WebKit Commit Bot 2014-11-04 16:48:01 PST
Attachment 240978 [details] did not pass style-queue:

ERROR: Source/WebCore/ChangeLog:10:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 11 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Tim Horton 2014-11-04 16:50:28 PST
Comment on attachment 240978 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=240978&action=review

> Source/WebKit2/UIProcess/PageClient.h:228
> +    virtual void dismissActionMenuDataDetetcorPopovers() = 0;


> Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:167
> +    // that and know whether or not it succeeded, so we'll settle for unachoring.

Comment 4 Beth Dakin 2014-11-04 21:42:55 PST
Thanks Tim! http://trac.webkit.org/changeset/175609
Comment 5 Beth Dakin 2014-11-04 21:52:37 PST
Build fix http://trac.webkit.org/changeset/175610