Bug 138381 - Disable flakey float32-repeat-out-of-bounds.js and int8-repeat-out-of-bounds.js tests for ARM64
Summary: Disable flakey float32-repeat-out-of-bounds.js and int8-repeat-out-of-bounds....
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-11-04 15:46 PST by Michael Saboff
Modified: 2014-11-05 15:20 PST (History)
2 users (show)

See Also:


Attachments
Patch (1.64 KB, patch)
2014-11-04 15:48 PST, Michael Saboff
no flags Details | Formatted Diff | Diff
Updated patch (1.83 KB, patch)
2014-11-05 15:17 PST, Michael Saboff
mark.lam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2014-11-04 15:46:30 PST
These tests are flakey when run on ARM64.  These test will be disabled, fixed and then re-enabled.  They die about half the time with output like:

[2014-11-04 14:11:28] INFO: Running stress/float32-repeat-out-of-bounds.js.ftl-no-cjit-validate
[2014-11-04 14:11:28] INFO: stress/float32-repeat-out-of-bounds.js.ftl-no-cjit-no-inline-validate: Exception: Error: unexpected retry count: 1
[2014-11-04 14:11:28] INFO: stress/float32-repeat-out-of-bounds.js.ftl-no-cjit-no-inline-validate: ERROR: Unexpected exit code: 3

and 

[2014-11-04 14:09:09] INFO: Running stress/int8-repeat-out-of-bounds.js.ftl-no-cjit-validate
[2014-11-04 14:09:09] INFO: stress/int8-repeat-out-of-bounds.js.ftl-no-cjit-validate: Exception: Error: unexpected retry count: 1
[2014-11-04 14:09:09] INFO: stress/int8-repeat-out-of-bounds.js.ftl-no-cjit-validate: ERROR: Unexpected exit code: 3
Comment 1 Michael Saboff 2014-11-04 15:48:25 PST
Created attachment 240970 [details]
Patch
Comment 2 Mark Lam 2014-11-04 16:09:14 PST
Comment on attachment 240970 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2014-11-04 16:29:16 PST
Comment on attachment 240970 [details]
Patch

Clearing flags on attachment: 240970

Committed r175587: <http://trac.webkit.org/changeset/175587>
Comment 4 WebKit Commit Bot 2014-11-04 16:29:19 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 Geoffrey Garen 2014-11-04 17:03:54 PST
Can you file a follow-up bug and mention it here in this bug report?
Comment 6 Michael Saboff 2014-11-04 17:28:27 PST
Bug to fix the tests is <https://bugs.webkit.org/show_bug.cgi?id=138391> - "Fix flakey float32-repeat-out-of-bounds.js and int8-repeat-out-of-bounds.js tests for ARM64"
Comment 7 Michael Saboff 2014-11-05 15:16:31 PST
Original change didn't disable the tests.
Comment 8 Michael Saboff 2014-11-05 15:17:41 PST
Created attachment 241060 [details]
Updated patch
Comment 9 Mark Lam 2014-11-05 15:19:30 PST
Comment on attachment 241060 [details]
Updated patch

rs=me
Comment 10 Michael Saboff 2014-11-05 15:20:20 PST
Committed r175644: <http://trac.webkit.org/changeset/175644>