Bug 138377 - Remove two unused ScrollingCoordinator methods.
Summary: Remove two unused ScrollingCoordinator methods.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-11-04 15:03 PST by Andreas Kling
Modified: 2014-11-04 15:14 PST (History)
6 users (show)

See Also:

Attachments
Patch (2.71 KB, patch)
2014-11-04 15:03 PST, Andreas Kling 		no flags Details | Formatted Diff | Diff
Patch II (2.40 KB, patch)
2014-11-04 15:08 PST, Andreas Kling 		cdumez: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2014-11-04 15:03:19 PST 
These functions appear to be unused:

scrollLayerForScrollableArea
horizontalScrollbarLayerForScrollableArea
verticalScrollbarLayerForScrollableArea
Comment 1 Andreas Kling 2014-11-04 15:03:46 PST 
Created attachment 240954 [details]
Patch
Comment 2 Chris Dumez 2014-11-04 15:06:17 PST 
Comment on attachment 240954 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240954&action=review

> Source/WebCore/page/scrolling/ScrollingCoordinator.h:-211
> -    static GraphicsLayer* scrollLayerForScrollableArea(ScrollableArea*);

Isn't this used for CoordinatedGraphics? Source/WebCore/page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.cpp
Comment 3 Andreas Kling 2014-11-04 15:07:04 PST 
(In reply to comment #2)
> Comment on attachment 240954 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=240954&action=review
> 
> > Source/WebCore/page/scrolling/ScrollingCoordinator.h:-211
> > -    static GraphicsLayer* scrollLayerForScrollableArea(ScrollableArea*);
> 
> Isn't this used for CoordinatedGraphics?
> Source/WebCore/page/scrolling/coordinatedgraphics/
> ScrollingCoordinatorCoordinatedGraphics.cpp

Whoops! Right you are.
Comment 4 Andreas Kling 2014-11-04 15:08:50 PST 
Created attachment 240955 [details]
Patch II
Comment 5 Chris Dumez 2014-11-04 15:09:19 PST 
Comment on attachment 240955 [details]
Patch II

r=me
Comment 6 Andreas Kling 2014-11-04 15:14:25 PST 
Committed r175584: <http://trac.webkit.org/changeset/175584>