Bug 138367 - RenderBox shouldn't need a pre-destructor hook.
Summary: RenderBox shouldn't need a pre-destructor hook.
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
Depends on:
Reported: 2014-11-04 13:04 PST by Andreas Kling
Modified: 2014-11-04 14:16 PST (History)
5 users (show)

See Also:

Patch (3.01 KB, patch)
2014-11-04 13:05 PST, Andreas Kling
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2014-11-04 13:04:12 PST
RenderBox::willBeDestroyed() does a couple of things, but none of them require the renderer to be in-tree, nor does it do any virtual dispatch.
We should move the logic to the plain destructor and get rid of the hook.
Comment 1 Andreas Kling 2014-11-04 13:05:37 PST
Created attachment 240942 [details]
Comment 2 WebKit Commit Bot 2014-11-04 14:16:47 PST
Comment on attachment 240942 [details]

Clearing flags on attachment: 240942

Committed r175580: <http://trac.webkit.org/changeset/175580>
Comment 3 WebKit Commit Bot 2014-11-04 14:16:51 PST
All reviewed patches have been landed.  Closing bug.