Dictionary lookup panel pops up at random when clicking on selected text
Created attachment 240915 [details] Patch
Created attachment 240916 [details] Patch
<rdar://problem/18861406>
Comment on attachment 240916 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=240916&action=review r=me > Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm:525 > +static PassRefPtr<Range> rangeForDictionaryLookupForSelection(Frame* frame, const VisibleSelection& selection, NSDictionary **options) 'frame' is not used for anything here.
Comment on attachment 240916 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=240916&action=review >> Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm:525 >> +static PassRefPtr<Range> rangeForDictionaryLookupForSelection(Frame* frame, const VisibleSelection& selection, NSDictionary **options) > > 'frame' is not used for anything here. Quite! Thanks for your review.
http://trac.webkit.org/changeset/175517
Follow up fix in http://trac.webkit.org/changeset/175524