Bug 138353 - Dictionary lookup panel pops up at random when clicking on selected text
Summary: Dictionary lookup panel pops up at random when clicking on selected text
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-11-03 23:28 PST by Tim Horton
Modified: 2014-11-04 00:20 PST (History)
4 users (show)

See Also:


Attachments
Patch (7.06 KB, patch)
2014-11-03 23:29 PST, Tim Horton
no flags Details | Formatted Diff | Diff
Patch (7.24 KB, patch)
2014-11-03 23:31 PST, Tim Horton
kling: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2014-11-03 23:28:32 PST
Dictionary lookup panel pops up at random when clicking on selected text
Comment 1 Tim Horton 2014-11-03 23:29:35 PST
Created attachment 240915 [details]
Patch
Comment 2 Tim Horton 2014-11-03 23:31:30 PST
Created attachment 240916 [details]
Patch
Comment 3 Tim Horton 2014-11-03 23:31:50 PST
<rdar://problem/18861406>
Comment 4 Andreas Kling 2014-11-03 23:44:27 PST
Comment on attachment 240916 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240916&action=review

r=me

> Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm:525
> +static PassRefPtr<Range> rangeForDictionaryLookupForSelection(Frame* frame, const VisibleSelection& selection, NSDictionary **options)

'frame' is not used for anything here.
Comment 5 Tim Horton 2014-11-03 23:45:15 PST
Comment on attachment 240916 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240916&action=review

>> Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm:525
>> +static PassRefPtr<Range> rangeForDictionaryLookupForSelection(Frame* frame, const VisibleSelection& selection, NSDictionary **options)
> 
> 'frame' is not used for anything here.

Quite! Thanks for your review.
Comment 6 Tim Horton 2014-11-04 00:05:41 PST
http://trac.webkit.org/changeset/175517
Comment 7 Tim Horton 2014-11-04 00:20:58 PST
Follow up fix in http://trac.webkit.org/changeset/175524