Bug 138351 – Add button and enable optimized fullscreen.

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Jeremy Jones]

Add button and enable optimized fullscreen.

[Jeremy Jones]

rdar://problem/18518262

[Jeremy Jones]

Created attachment 240914 [details]
Patch

[Eric Carlson]

Comment on attachment 240914 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240914&action=review

You might want to put the WKSI parts, along with an updated library, into a separate patch.

> Source/WebCore/Modules/mediacontrols/mediaControlsiOS.js:330
> +        if (event.scale > 1.2 || event.scale < 0.8)

Nit: these should be constants

> Source/WebCore/Modules/mediacontrols/mediaControlsiOS.js:343
> +        if (velocity < 2 || event.scale < 1.25)

Ditto.

> Source/WebCore/Modules/mediacontrols/mediaControlsiOS.js:366
> +                    if (now - this.lastDoubleTouchTime < 300) {

Ditto.

[Jeremy Jones]

Created attachment 240936 [details]
Patch

[Jeremy Jones]

Created attachment 240943 [details]
Patch

[Jeremy Jones]

Created attachment 240967 [details]
Patch

[Jeremy Jones]

(In reply to comment #3)
> Comment on attachment 240914 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=240914&action=review
> 
> You might want to put the WKSI parts, along with an updated library, into a
> separate patch.

WKSI checked in.

> 
> > Source/WebCore/Modules/mediacontrols/mediaControlsiOS.js:330
> > +        if (event.scale > 1.2 || event.scale < 0.8)
> 
> Nit: these should be constants

Done

> 
> > Source/WebCore/Modules/mediacontrols/mediaControlsiOS.js:343
> > +        if (velocity < 2 || event.scale < 1.25)
> 
> Ditto.

Done.

> 
> > Source/WebCore/Modules/mediacontrols/mediaControlsiOS.js:366
> > +                    if (now - this.lastDoubleTouchTime < 300) {
> 
> Ditto.

Done.

[Jeremy Jones]

Committed r175596

[Jon Lee]

Comment on attachment 240967 [details]
Patch

Removing r? to remove from the review queue