Add button and enable optimized fullscreen.
rdar://problem/18518262
Created attachment 240914 [details] Patch
Comment on attachment 240914 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=240914&action=review You might want to put the WKSI parts, along with an updated library, into a separate patch. > Source/WebCore/Modules/mediacontrols/mediaControlsiOS.js:330 > + if (event.scale > 1.2 || event.scale < 0.8) Nit: these should be constants > Source/WebCore/Modules/mediacontrols/mediaControlsiOS.js:343 > + if (velocity < 2 || event.scale < 1.25) Ditto. > Source/WebCore/Modules/mediacontrols/mediaControlsiOS.js:366 > + if (now - this.lastDoubleTouchTime < 300) { Ditto.
Created attachment 240936 [details] Patch
Created attachment 240943 [details] Patch
Created attachment 240967 [details] Patch
(In reply to comment #3) > Comment on attachment 240914 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=240914&action=review > > You might want to put the WKSI parts, along with an updated library, into a > separate patch. WKSI checked in. > > > Source/WebCore/Modules/mediacontrols/mediaControlsiOS.js:330 > > + if (event.scale > 1.2 || event.scale < 0.8) > > Nit: these should be constants Done > > > Source/WebCore/Modules/mediacontrols/mediaControlsiOS.js:343 > > + if (velocity < 2 || event.scale < 1.25) > > Ditto. Done. > > > Source/WebCore/Modules/mediacontrols/mediaControlsiOS.js:366 > > + if (now - this.lastDoubleTouchTime < 300) { > > Ditto. Done.
Committed r175596
Comment on attachment 240967 [details] Patch Removing r? to remove from the review queue