Bug 138340 - Implement yellow highlight over data detected items
Summary: Implement yellow highlight over data detected items
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-11-03 17:35 PST by Tim Horton
Modified: 2014-11-04 12:46 PST (History)
9 users (show)

See Also:

Attachments
patch (66.60 KB, patch)
2014-11-03 17:36 PST, Tim Horton 		no flags Details | Formatted Diff | Diff
rebase (66.55 KB, patch)
2014-11-03 17:40 PST, Tim Horton 		no flags Details | Formatted Diff | Diff
patch (58.54 KB, patch)
2014-11-03 20:10 PST, Tim Horton 		andersca: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2014-11-03 17:35:16 PST 
<rdar://problem/18840102>
Comment 1 Tim Horton 2014-11-03 17:36:16 PST 
Created attachment 240887 [details]
patch
Comment 2 Tim Horton 2014-11-03 17:40:05 PST 
Created attachment 240889 [details]
rebase
Comment 3 WebKit Commit Bot 2014-11-03 17:41:25 PST 
Attachment 240889 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:357:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 1 in 26 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Tim Horton 2014-11-03 18:15:29 PST 
Andersca sez "use unique_ptr for TextIndicator" and "make sure there's not a refcycle with the completion block".
Comment 5 Tim Horton 2014-11-03 20:10:01 PST 
Created attachment 240903 [details]
patch

un-did the un-refcounting of TextIndicator; we can switch to unique_ptr later if we want.
Comment 6 WebKit Commit Bot 2014-11-03 20:13:02 PST 
Attachment 240903 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:358:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 1 in 17 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Tim Horton 2014-11-04 11:43:09 PST 
http://trac.webkit.org/changeset/175564
Comment 8 Tim Horton 2014-11-04 12:46:00 PST 
And http://trac.webkit.org/changeset/175568