Bug 138338 - Web Inspector: Uncaught Exceptions when paused and hovering JavaScript without CallFrames
Summary: Web Inspector: Uncaught Exceptions when paused and hovering JavaScript withou...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-11-03 17:12 PST by Joseph Pecoraro
Modified: 2014-11-04 11:39 PST (History)
6 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (2.18 KB, patch)
2014-11-03 17:13 PST, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2014-11-03 17:12:01 PST 
* SUMMARY
Uncaught Exceptions when paused and hovering JavaScript without CallFrames
SourceCodeTextEditor.js:1214:"undefined is not an object (evaluating 'WebInspector.debuggerManager.activeCallFrame.id')"

* STEPS TO REPRODUCE
1. Inspect <http://bogojoker.com/shell/>
2. Enable Pause on all exceptions
3. js> setTimeout(function(){[].x.x})
4. When paused, hover over any JavaScript, e.g. "document" in the index.html
  => Exception

* NOTES
Maybe we should show at least one call frame here, but in the meantime, we should handle the exception.
Comment 1 Radar WebKit Bug Importer 2014-11-03 17:12:46 PST 
<rdar://problem/18861394>
Comment 2 Joseph Pecoraro 2014-11-03 17:13:12 PST 
Created attachment 240883 [details]
[PATCH] Proposed Fix
Comment 3 Geoffrey Garen 2014-11-04 11:01:52 PST 
Comment on attachment 240883 [details]
[PATCH] Proposed Fix

r=me

Can you file a follow-up bug about showing a call frame in this case? It seems like we should / should be able to.
Comment 4 WebKit Commit Bot 2014-11-04 11:39:12 PST 
Comment on attachment 240883 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 240883

Committed r175563: <http://trac.webkit.org/changeset/175563>
Comment 5 WebKit Commit Bot 2014-11-04 11:39:15 PST 
All reviewed patches have been landed.  Closing bug.