Bug 138316 - RenderCounter shouldn't need a pre-destructor hook.
Summary: RenderCounter shouldn't need a pre-destructor hook.
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
Depends on:
Reported: 2014-11-03 10:37 PST by Andreas Kling
Modified: 2014-11-03 12:17 PST (History)
5 users (show)

See Also:

Patch (2.22 KB, patch)
2014-11-03 10:54 PST, Andreas Kling
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2014-11-03 10:37:46 PST
RenderCounter has a willBeDestroyed() hook, but it doesn't actually need it.
It was done that way originally because there were no guarantees about calling RenderObject::view() in a renderer destructor.
These days that's not a problem. Even if you are the RenderView. For real.
Comment 1 Andreas Kling 2014-11-03 10:54:57 PST
Created attachment 240863 [details]
Comment 2 WebKit Commit Bot 2014-11-03 12:17:39 PST
Comment on attachment 240863 [details]

Clearing flags on attachment: 240863

Committed r175485: <http://trac.webkit.org/changeset/175485>
Comment 3 WebKit Commit Bot 2014-11-03 12:17:43 PST
All reviewed patches have been landed.  Closing bug.