Bug 138306 - 'noreturn' function does return warning in LLVMOverrides.cpp
Summary: 'noreturn' function does return warning in LLVMOverrides.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-11-03 04:02 PST by Akos Kiss
Modified: 2014-11-10 00:00 PST (History)
5 users (show)

See Also:

Attachments
Proposed patch. (1.88 KB, patch)
2014-11-03 04:04 PST, Akos Kiss 		no flags Details | Formatted Diff | Diff
Proposed patch, v2 (3.17 KB, patch)
2014-11-03 04:44 PST, Akos Kiss 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Akos Kiss 2014-11-03 04:02:03 PST 
When building with FTL JIT enabled (on x86_64/Linux), gcc is emitting the following warning:

[71/651] Building CXX object Source/JavaScriptCore/CMakeFiles/llvmForJSC.dir/llvm/library/LLVMOverrides.cpp.o
../../Source/JavaScriptCore/llvm/library/LLVMOverrides.cpp: In function ‘void abort()’:
../../Source/JavaScriptCore/llvm/library/LLVMOverrides.cpp:57:1: warning: ‘noreturn’ function does return [enabled by default]
 }
 ^

No big issue, but it would be better to get rid of it.
Comment 1 Akos Kiss 2014-11-03 04:04:37 PST 
Created attachment 240839 [details]
Proposed patch.

No regressions on x86_64/Linux/GTK
Comment 2 Akos Kiss 2014-11-03 04:44:38 PST 
Created attachment 240840 [details]
Proposed patch, v2

Mac seems to be more rigorous. Adding more NO_RETURNs.
Comment 3 WebKit Commit Bot 2014-11-10 00:00:40 PST 
Comment on attachment 240840 [details]
Proposed patch, v2

Clearing flags on attachment: 240840

Committed r175802: <http://trac.webkit.org/changeset/175802>
Comment 4 WebKit Commit Bot 2014-11-10 00:00:44 PST 
All reviewed patches have been landed.  Closing bug.